From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A95A3C4551; Mon, 23 Mar 2026 16:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283294; cv=none; b=alo9LRZ8p7jfJIewe2NzjjFGPKlQAISsoVOVJ0l7PLOA65zxtK3kpVrtaFEkXLhrXObkNj25y9LUZire4cdnYio7ISRfs+f5ijnPfewfKMvFsWeQfU3l+UX7QeN+HUYPlJ7F+y5+zUJ1183zsBK7XWhgLuoEHsk/WQVKPKN3kE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283294; c=relaxed/simple; bh=Rx6rJH/+4cXUHoOsj6s+4/m2CZOI0NlHF61pQPHqKUM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=JmG3C0v4HMtfNj/QAiFnme3Sula5whgAg9HOuuX/++xeix3wzNLgyxsDfvnQJTmd4c+DxBvH1oagHKDArc3TOLVULHI7klp+mL9mb6/LHhPUrCXI72YtTaYYX6GuT/m+HQhgHqdu6byX9lEXf2mQ5BFPE9E87nmBhJDvXQMP6Bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s0xWgvw4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s0xWgvw4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F75AC4CEF7; Mon, 23 Mar 2026 16:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774283293; bh=Rx6rJH/+4cXUHoOsj6s+4/m2CZOI0NlHF61pQPHqKUM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=s0xWgvw47l62SuNbeKJi4hbZOVOzYJZvTJuNGoCLE5oqucy7IYI4nylOk+kIZZJLG ec26tYUH16OqC6Zdxj8eUY7llBi217MUnTzBCn2EIzczhhXiwBoYghoWJdC8AvfBMj XVKS+umiizK7uyQycr3WOxemjD2X3Zobdnl1pijETuVl61ONNUO6kzv9aZrUKCSctr YrZcsAII+NAfp/98wVH2MHSHKDHd2h1lHO9a4lA2zzsN9kjOX4S2qk7ZqYbS1eszB4 WpdcjmAb41gFZcX9Mx9o1z8oulNyvQ64meTyMM9rHXkvHQrNiSrb2M59nm3lFz9ADM guWrtgWaj7/ZA== Date: Mon, 23 Mar 2026 11:28:10 -0500 From: Bjorn Helgaas To: Chen-Yu Tsai Cc: Bartosz Golaszewski , Manivannan Sadhasivam , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Bartosz Golaszewski Subject: Re: [PATCH v2] PCI/pwrctrl: Do not power off on pwrctrl device removal Message-ID: <20260323162810.GA826479@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226092234.3859740-1-wenst@chromium.org> On Thu, Feb 26, 2026 at 05:22:33PM +0800, Chen-Yu Tsai wrote: > With the move to explicit pwrctrl power on/off APIs, the caller, i.e. > the PCI driver should manage the power state. The pwrctrl drivers should > not try to clean up or power off when they are removed, as this might > end up disabling an already disabled regulator, causing a big warning. > This can be triggered if a PCI controller driver's .remove() callback > calls pci_pwrctrl_destroy_devices() after pci_pwrctrl_power_off_devices(). > > Drop the devm cleanup parts that turn off regulators from the pwrctrl > drivers. > > Fixes: b921aa3f8dec ("PCI/pwrctrl: Switch to pwrctrl create, power on/off, destroy APIs") > Cc: Manivannan Sadhasivam > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Bartosz Golaszewski Applied to pci/for-linus for v7.0, thanks! > --- > Changes since v1: > - Keep the release function for the PCI slot driver to free the > regulators > > I ran into this while integrating the new pci_pwrctrl_*() API into the > MediaTek driver. I am sending this separately since this change is > unrelated and does not conflict with or depend on the other changes for > the driver itself. > > I think this should be merged for fixes. > > --- > drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c | 12 ------------ > drivers/pci/pwrctrl/slot.c | 1 - > 2 files changed, 13 deletions(-) > > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c b/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c > index 0d0377283c37..c7e4beec160a 100644 > --- a/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-pwrseq.c > @@ -68,13 +68,6 @@ static int pwrseq_pwrctrl_power_off(struct pci_pwrctrl *pwrctrl) > return pwrseq_power_off(pwrseq->pwrseq); > } > > -static void devm_pwrseq_pwrctrl_power_off(void *data) > -{ > - struct pwrseq_pwrctrl *pwrseq = data; > - > - pwrseq_pwrctrl_power_off(&pwrseq->pwrctrl); > -} > - > static int pwrseq_pwrctrl_probe(struct platform_device *pdev) > { > const struct pwrseq_pwrctrl_pdata *pdata; > @@ -101,11 +94,6 @@ static int pwrseq_pwrctrl_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(pwrseq->pwrseq), > "Failed to get the power sequencer\n"); > > - ret = devm_add_action_or_reset(dev, devm_pwrseq_pwrctrl_power_off, > - pwrseq); > - if (ret) > - return ret; > - > pwrseq->pwrctrl.power_on = pwrseq_pwrctrl_power_on; > pwrseq->pwrctrl.power_off = pwrseq_pwrctrl_power_off; > > diff --git a/drivers/pci/pwrctrl/slot.c b/drivers/pci/pwrctrl/slot.c > index 082af81efe25..b87639253ae2 100644 > --- a/drivers/pci/pwrctrl/slot.c > +++ b/drivers/pci/pwrctrl/slot.c > @@ -63,7 +63,6 @@ static void devm_slot_pwrctrl_release(void *data) > { > struct slot_pwrctrl *slot = data; > > - slot_pwrctrl_power_off(&slot->pwrctrl); > regulator_bulk_free(slot->num_supplies, slot->supplies); > } > > -- > 2.53.0.414.gf7e9f6c205-goog >