From: carlos.bilbao@kernel.org
To: mani@kernel.org, kwilczynski@kernel.org, kishon@kernel.org
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bilbao@vt.edu, Carlos Bilbao <carlos.bilbao@kernel.org>
Subject: [PATCH 0/2] misc: pci_endpoint_test: doorbell fixes
Date: Fri, 3 Apr 2026 18:20:00 -0700 [thread overview]
Message-ID: <20260404012002.111873-1-carlos.bilbao@kernel.org> (raw)
From: Carlos Bilbao <carlos.bilbao@kernel.org>
pci_endpoint_test_doorbell() reads the BAR number from the endpoint's test
register space and uses it directly as an index into test->bar[] without
bounds checking. Since the value is a raw u32 written by the endpoint
firmware, any value is possible; values >= PCI_STD_NUM_BARS result in an
out-of-bounds array access.
Patch 1 adds the missing bounds check.
Patch 2 removes a dead read of the same register that precedes the writel
sequence; the DB_BAR register carries no read side effect and the assigned
value is unconditionally overwritten before use.
Carlos Bilbao (2):
misc: pci_endpoint_test: validate BAR index in doorbell test
misc: pci_endpoint_test: remove dead BAR read before doorbell trigger
---
drivers/misc/pci_endpoint_test.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
next reply other threads:[~2026-04-04 1:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 1:20 carlos.bilbao [this message]
2026-04-04 1:20 ` [PATCH 1/2] misc: pci_endpoint_test: validate BAR index in doorbell test carlos.bilbao
2026-04-06 16:39 ` Koichiro Den
2026-04-10 22:47 ` Carlos Bilbao
2026-04-04 1:20 ` [PATCH 2/2] misc: pci_endpoint_test: remove dead BAR read before doorbell trigger carlos.bilbao
2026-04-06 16:41 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260404012002.111873-1-carlos.bilbao@kernel.org \
--to=carlos.bilbao@kernel.org \
--cc=arnd@arndb.de \
--cc=bilbao@vt.edu \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox