From: Zhi Wang <zhiw@nvidia.com>
To: <rust-for-linux@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <dakr@kernel.org>, <aliceryhl@google.com>, <bhelgaas@google.com>,
<kwilczynski@kernel.org>, <ojeda@kernel.org>, <boqun@kernel.org>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>, <tmgross@umich.edu>,
<markus.probst@posteo.de>, <cjia@nvidia.com>, <smitra@nvidia.com>,
<ankita@nvidia.com>, <aniketa@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <acourbot@nvidia.com>,
<joelagnelf@nvidia.com>, <jhubbard@nvidia.com>,
<kjaju@nvidia.com>, <zhiwang@kernel.org>,
Zhi Wang <zhiw@nvidia.com>
Subject: [PATCH v3 1/1] rust: pci: add extended capability and SR-IOV support
Date: Thu, 9 Apr 2026 21:52:54 +0300 [thread overview]
Message-ID: <20260409185254.3869808-2-zhiw@nvidia.com> (raw)
In-Reply-To: <20260409185254.3869808-1-zhiw@nvidia.com>
Introduce extended PCI capability support in rust PCI abstraction.
Implement ExtCapability<T> for PCI extended capability regions. It
delegates IoCapable to the underlying ConfigSpace, so io_project!/io_read!
/io_write! work directly on capability register structs.
Also add a rust helper for the PCI_EXT_CAP_NEXT() macro.
Link: https://lore.kernel.org/rust-for-linux/20260126215957.541180-1-zhiw@nvidia.com/
Cc: Gary Guo <gary@garyguo.net>
Signed-off-by: Zhi Wang <zhiw@nvidia.com>
---
rust/helpers/pci.c | 5 +
rust/kernel/pci.rs | 7 ++
rust/kernel/pci/cap.rs | 256 +++++++++++++++++++++++++++++++++++++++++
3 files changed, 268 insertions(+)
create mode 100644 rust/kernel/pci/cap.rs
diff --git a/rust/helpers/pci.c b/rust/helpers/pci.c
index e44905317d75..5043c9909d44 100644
--- a/rust/helpers/pci.c
+++ b/rust/helpers/pci.c
@@ -24,6 +24,11 @@ __rust_helper bool rust_helper_dev_is_pci(const struct device *dev)
return dev_is_pci(dev);
}
+__rust_helper u32 rust_helper_pci_ext_cap_next(u32 header)
+{
+ return PCI_EXT_CAP_NEXT(header);
+}
+
#ifndef CONFIG_PCI_MSI
__rust_helper int rust_helper_pci_alloc_irq_vectors(struct pci_dev *dev,
unsigned int min_vecs,
diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs
index af74ddff6114..962c6656dc96 100644
--- a/rust/kernel/pci.rs
+++ b/rust/kernel/pci.rs
@@ -31,10 +31,17 @@
},
};
+mod cap;
mod id;
mod io;
mod irq;
+pub use self::cap::{
+ ExtCapId,
+ ExtCapability,
+ ExtSriovCapability,
+ ExtSriovRegs, //
+};
pub use self::id::{
Class,
ClassMask,
diff --git a/rust/kernel/pci/cap.rs b/rust/kernel/pci/cap.rs
new file mode 100644
index 000000000000..1a25ef4cc633
--- /dev/null
+++ b/rust/kernel/pci/cap.rs
@@ -0,0 +1,256 @@
+// SPDX-License-Identifier: GPL-2.0
+
+//! PCI extended capability support.
+
+use super::{
+ ConfigSpace,
+ Extended, //
+};
+use crate::{
+ bindings,
+ io::{
+ Io,
+ IoCapable,
+ Region, //
+ },
+ prelude::*,
+ ptr::KnownSize, //
+};
+
+/// PCI extended capability IDs.
+#[repr(u16)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum ExtCapId {
+ /// Single Root I/O Virtualization.
+ // CAST: `PCI_EXT_CAP_ID_SRIOV` is `0x10`, which fits in `u16`.
+ Sriov = bindings::PCI_EXT_CAP_ID_SRIOV as u16,
+}
+
+impl ExtCapId {
+ fn as_raw(self) -> u16 {
+ self as u16
+ }
+}
+
+/// An extended PCI capability that implements [`Io`].
+///
+/// # Examples
+///
+/// ```no_run
+/// use kernel::pci::{
+/// self,
+/// ExtSriovCapability, //
+/// };
+/// use kernel::io::Io;
+///
+/// fn probe_sriov(pdev: &pci::Device<kernel::device::Core>) -> Result<(), kernel::error::Error> {
+/// let config = pdev.config_space_extended()?;
+/// let sriov = ExtSriovCapability::find(&config)?;
+///
+/// let total_vfs = kernel::io_read!(&sriov, .total_vfs);
+/// let vf_offset = kernel::io_read!(&sriov, .vf_offset);
+/// let bar0 = kernel::io_read!(&sriov, .vf_bar[0]);
+/// kernel::io_write!(&sriov, .num_vfs, 4u16);
+/// let bar0_64 = sriov.read_vf_bar64(0)?;
+///
+/// Ok(())
+/// }
+/// ```
+///
+/// # Invariants
+///
+/// `ptr` is within the device's extended configuration space at a valid
+/// capability. For sized `T`, the region is at least `size_of::<T>()` bytes.
+pub struct ExtCapability<'a, T: ?Sized + KnownSize = Region<0>> {
+ config: &'a ConfigSpace<'a, Extended>,
+ ptr: *mut T,
+}
+
+impl<T: ?Sized + KnownSize> Io for ExtCapability<'_, T> {
+ type Type = T;
+
+ #[inline]
+ fn as_ptr(&self) -> *mut T {
+ self.ptr
+ }
+}
+
+macro_rules! impl_ext_cap_io_capable {
+ ($ty:ty) => {
+ impl<T: ?Sized + KnownSize> IoCapable<$ty> for ExtCapability<'_, T> {
+ #[inline]
+ unsafe fn io_read(&self, address: *mut $ty) -> $ty {
+ // SAFETY: The caller guarantees `address` is within bounds of
+ // this capability, which is within the config space.
+ unsafe { self.config.io_read(address) }
+ }
+
+ #[inline]
+ unsafe fn io_write(&self, value: $ty, address: *mut $ty) {
+ // SAFETY: The caller guarantees `address` is within bounds of
+ // this capability, which is within the config space.
+ unsafe { self.config.io_write(value, address) }
+ }
+ }
+ };
+}
+
+impl_ext_cap_io_capable!(u8);
+impl_ext_cap_io_capable!(u16);
+impl_ext_cap_io_capable!(u32);
+
+impl<'a> ExtCapability<'a> {
+ /// Base offset of this capability in configuration space.
+ #[inline]
+ pub fn offset(&self) -> usize {
+ self.ptr.addr()
+ }
+
+ /// Size of this capability region in bytes.
+ #[inline]
+ pub fn size(&self) -> usize {
+ KnownSize::size(self.ptr)
+ }
+
+ /// Cast to a typed capability, checking that the region is large enough.
+ pub fn cast_sized<U>(self) -> Result<ExtCapability<'a, U>> {
+ if self.size() < core::mem::size_of::<U>() {
+ return Err(EINVAL);
+ }
+
+ // INVARIANT: `self` already satisfies the invariant (ptr is within extended config
+ // space at a valid capability), and the size check above guarantees the region is at
+ // least `size_of::<U>()` bytes.
+ Ok(ExtCapability {
+ config: self.config,
+ ptr: core::ptr::without_provenance_mut(self.offset()),
+ })
+ }
+}
+
+impl ConfigSpace<'_, Extended> {
+ /// Finds an extended capability by ID, returning an untyped [`ExtCapability`].
+ pub fn find_ext_capability(&self, cap: ExtCapId) -> Result<ExtCapability<'_>> {
+ let offset = usize::from(
+ // SAFETY: `self.pdev` is valid by the type invariant of `ConfigSpace`.
+ unsafe {
+ bindings::pci_find_ext_capability(self.pdev.as_raw(), i32::from(cap.as_raw()))
+ },
+ );
+
+ if offset == 0 {
+ return Err(ENODEV);
+ }
+
+ Ok(self.make_ext_capability(offset))
+ }
+
+ /// Finds the next extended capability with `cap` after `start`.
+ pub fn find_next_ext_capability(&self, start: u16, cap: ExtCapId) -> Result<ExtCapability<'_>> {
+ let offset = usize::from(
+ // SAFETY: `self.pdev` is valid by the type invariant of `ConfigSpace`.
+ unsafe {
+ bindings::pci_find_next_ext_capability(
+ self.pdev.as_raw(),
+ start,
+ i32::from(cap.as_raw()),
+ )
+ },
+ );
+
+ if offset == 0 {
+ return Err(ENODEV);
+ }
+
+ Ok(self.make_ext_capability(offset))
+ }
+
+ fn make_ext_capability(&self, offset: usize) -> ExtCapability<'_> {
+ let size = self.calculate_ext_cap_size(offset);
+
+ let ptr = core::ptr::slice_from_raw_parts_mut::<u8>(
+ core::ptr::without_provenance_mut(offset),
+ size,
+ // CAST: `Region<0>` is a DST like `[u8]`, so this pointer cast preserves metadata.
+ ) as *mut Region<0>;
+
+ // INVARIANT: `offset` was returned by `pci_find_ext_capability` /
+ // `pci_find_next_ext_capability`, which guarantees it points to a valid capability
+ // within the extended configuration space. `size` is bounded by the next capability
+ // offset or the end of the configuration space.
+ ExtCapability { config: self, ptr }
+ }
+
+ fn calculate_ext_cap_size(&self, offset: usize) -> usize {
+ let header = self.try_read32(offset).unwrap_or(0);
+ // SAFETY: Pure bit manipulation, no preconditions.
+ // CAST: The next-cap pointer is a 12-bit field (max 0xFFC), always fits in `usize`.
+ let next_ptr = unsafe { bindings::pci_ext_cap_next(header) } as usize;
+
+ if next_ptr > offset {
+ next_ptr - offset
+ } else {
+ KnownSize::size(self.as_ptr()) - offset
+ }
+ }
+}
+
+/// SR-IOV register layout per PCIe spec (64 bytes starting at cap offset).
+#[repr(C)]
+pub struct ExtSriovRegs {
+ /// Extended capability header.
+ pub header: u32,
+ /// SR-IOV capabilities.
+ pub cap: u32,
+ /// SR-IOV control.
+ pub ctrl: u16,
+ /// SR-IOV status.
+ pub status: u16,
+ /// Initial VFs.
+ pub initial_vfs: u16,
+ /// Total VFs.
+ pub total_vfs: u16,
+ /// Number of VFs.
+ pub num_vfs: u16,
+ /// Function dependency link.
+ pub func_dep_link: u16,
+ /// First VF offset.
+ pub vf_offset: u16,
+ /// VF stride.
+ pub vf_stride: u16,
+ _reserved: u16,
+ /// VF device ID.
+ pub vf_device_id: u16,
+ /// Supported page sizes.
+ pub supported_page_sizes: u32,
+ /// System page size.
+ pub system_page_size: u32,
+ /// VF BARs (BAR0–BAR5).
+ pub vf_bar: [u32; 6],
+ /// VF migration state array offset.
+ pub migration_state: u32,
+}
+
+/// SR-IOV capability. See [`ExtCapability`] for usage.
+pub type ExtSriovCapability<'a> = ExtCapability<'a, ExtSriovRegs>;
+
+impl ExtCapability<'_, ExtSriovRegs> {
+ /// Find the SR-IOV capability, or `ENODEV` if not present.
+ #[inline]
+ pub fn find<'a>(
+ config: &'a ConfigSpace<'_, Extended>,
+ ) -> Result<ExtCapability<'a, ExtSriovRegs>> {
+ config.find_ext_capability(ExtCapId::Sriov)?.cast_sized()
+ }
+
+ /// Reads a 64-bit VF BAR from two consecutive 32-bit slots.
+ #[inline]
+ pub fn read_vf_bar64(&self, bar_index: usize) -> Result<u64> {
+ if bar_index >= 5 {
+ return Err(EINVAL);
+ }
+ let low = crate::io_read!(self, .vf_bar[bar_index]?);
+ let high = crate::io_read!(self, .vf_bar[bar_index + 1]?);
+ Ok((u64::from(high) << 32) | u64::from(low))
+ }
+}
--
2.51.0
prev parent reply other threads:[~2026-04-09 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 18:52 [PATCH 0/1] Rust PCI capability infrastructure and SR-IOV support Zhi Wang
2026-04-09 18:52 ` Zhi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409185254.3869808-2-zhiw@nvidia.com \
--to=zhiw@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kjaju@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox