public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jacob Moroni <jmoroni@google.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	David Hu <xuehaohu@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/P2PDMA: Allow wildcard device IDs in host bridge list
Date: Fri, 10 Apr 2026 17:28:18 -0500	[thread overview]
Message-ID: <20260410222818.GA597166@bhelgaas> (raw)
In-Reply-To: <20260409150123.3538444-1-jmoroni@google.com>

On Thu, Apr 09, 2026 at 03:01:22PM +0000, Jacob Moroni wrote:
> Currently, the pci_p2pdma_whitelist array requires an exact match
> for both vendor and device ID. Some hardware vendors support cross
> bridge p2p across their entire silicon lineup, so add support for
> wildcard device IDs to avoid the need to continuously update this
> array.
> 
> Signed-off-by: Jacob Moroni <jmoroni@google.com>

Both applied to pci/p2pdma for v7.1, thanks!

> ---
>  drivers/pci/p2pdma.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index e0f546166..25e9358d0 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -530,7 +530,7 @@ static bool cpu_supports_p2pdma(void)
>  
>  static const struct pci_p2pdma_whitelist_entry {
>  	unsigned short vendor;
> -	unsigned short device;
> +	int device;
>  	enum {
>  		REQ_SAME_HOST_BRIDGE	= 1 << 0,
>  	} flags;
> @@ -601,8 +601,12 @@ static bool __host_bridge_whitelist(struct pci_host_bridge *host,
>  	device = root->device;
>  
>  	for (entry = pci_p2pdma_whitelist; entry->vendor; entry++) {
> -		if (vendor != entry->vendor || device != entry->device)
> +		if (vendor != entry->vendor)
>  			continue;
> +
> +		if (entry->device != PCI_ANY_ID && device != entry->device)
> +			continue;
> +
>  		if (entry->flags & REQ_SAME_HOST_BRIDGE && !same_host_bridge)
>  			return false;
>  
> -- 
> 2.53.0.1213.gd9a14994de-goog
> 

      parent reply	other threads:[~2026-04-10 22:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 15:01 [PATCH 1/2] PCI/P2PDMA: Allow wildcard device IDs in host bridge list Jacob Moroni
2026-04-09 15:01 ` [PATCH 2/2] PCI/P2PDMA: Add Google SoCs to the P2P DMA " Jacob Moroni
2026-04-09 22:47   ` Logan Gunthorpe
2026-04-09 22:47 ` [PATCH 1/2] PCI/P2PDMA: Allow wildcard device IDs in " Logan Gunthorpe
2026-04-10 22:28 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410222818.GA597166@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=jmoroni@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=xuehaohu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox