From: Bjorn Helgaas <helgaas@kernel.org>
To: Fu Hao <fuhao@open-hieco.net>
Cc: bhelgaas@google.com, perex@perex.cz, tiwai@suse.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 6/8] ALSA: hda: Add support for Hygon family 18h model 5h HD-Audio
Date: Fri, 10 Apr 2026 17:47:35 -0500 [thread overview]
Message-ID: <20260410224735.GA598593@bhelgaas> (raw)
In-Reply-To: <d68343d2e840bc2b0d466eb175ec2bc2f952771e.1775548724.git.fuhao@open-hieco.net>
On Tue, Apr 07, 2026 at 04:24:56PM +0800, Fu Hao wrote:
> Add the new PCI ID 0x1d94 0x14a9 for Hygon family 18h model 5h
> HDA controller.
>
> Signed-off-by: Fu Hao <fuhao@open-hieco.net>
> ---
> include/linux/pci_ids.h | 1 +
> sound/hda/controllers/intel.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 406abf629..19d968017 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2613,6 +2613,7 @@
> #define PCI_VENDOR_ID_ROCKCHIP 0x1d87
>
> #define PCI_VENDOR_ID_HYGON 0x1d94
> +#define PCI_DEVICE_ID_HYGON_18H_M05H_HDA 0x14a9
It looks like PCI_DEVICE_ID_HYGON_18H_M05H_HDA is only used in
sound/hda/controllers/intel.c, so it should probably be defined there
so you don't need to modify include/linux/pci_ids.h:
* Do not add new entries to this file unless the definitions
* are shared between multiple drivers.
prev parent reply other threads:[~2026-04-10 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1775548724.git.fuhao@open-hieco.net>
2026-04-07 8:24 ` [PATCH v2 6/8] ALSA: hda: Add support for Hygon family 18h model 5h HD-Audio Fu Hao
2026-04-10 22:47 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410224735.GA598593@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=fuhao@open-hieco.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox