Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Shuan He" <heshuan@bytedance.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/proc: Fix race between pci_proc_init() and pci_bus_add_device()
Date: Fri, 1 May 2026 10:22:56 +0900	[thread overview]
Message-ID: <20260501010127.GA990551@rocinante> (raw)
In-Reply-To: <20260430003542.455198-1-kwilczynski@kernel.org>

Hello,

> Thus, wrap the for_each_pci_dev() loop with pci_lock_rescan_remove() to
> serialise against concurrent PCI bus operations.  Add an early return in
> pci_proc_attach_device() when dev->procent is already set, making the
> function idempotent and symmetric with pci_proc_detach_device() which
> clears this field.

A note on testing:

  0-day bot (recent test runs; newer builds will arrive later):
    - https://lore.kernel.org/linux-pci/202603162306.2oKy0qcP-lkp@intel.com

  Sashiko's feedback:
    - https://sashiko.dev/#/patchset/20260430003542.455198-1-kwilczynski%40kernel.org

Lorenzo Pieralisi did some testing reported outside the mailing list (we
talked on IRC) on the platform he had some boot issues.  With this patch
applied, the problems seen before were resolved.

Thank you!

	Krzysztof

  reply	other threads:[~2026-05-01  1:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30  0:35 [PATCH] PCI/proc: Fix race between pci_proc_init() and pci_bus_add_device() Krzysztof Wilczyński
2026-05-01  1:22 ` Krzysztof Wilczyński [this message]
2026-05-01 19:37   ` Bjorn Helgaas
2026-05-05  9:47     ` Lorenzo Pieralisi
2026-05-05 23:53       ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260501010127.GA990551@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=heshuan@bytedance.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=lukas@wunner.de \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox