Re: [PATCH v17 01/11] PCI/AER: Introduce AER-CXL Kfifo

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Early exit in `for_each_cxl_proto_err()` strands remaining kfifo items and leaks `pci_dev` references.
--

commit fc9ac9cc58a6a77c19c9c8d750f3b41f9490529e
Author: Terry Bowman <terry.bowman@amd.com>

PCI/AER: Introduce AER-CXL Kfifo

This commit introduces a kfifo work queue to be used by the AER and CXL
drivers for CXL protocol error handling. It adds registration functions and
a cxl_forward_error() function to queue the errors with their associated
PCI device.

> diff --git a/drivers/pci/pcie/aer_cxl_vh.c b/drivers/pci/pcie/aer_cxl_vh.c
> new file mode 100644
> index 0000000000000..c0fea2c2b9bc6
> --- /dev/null
> +++ b/drivers/pci/pcie/aer_cxl_vh.c

[ ... ]

> +int for_each_cxl_proto_err(struct cxl_proto_err_work_data *wd,
> +			   cxl_proto_err_fn_t fn)
> +{
> +	int rc;
> +
> +	guard(rwsem_read)(&cxl_proto_err_kfifo.rwsem);
> +	while (kfifo_get(&cxl_proto_err_kfifo.fifo, wd)) {
> +		rc = fn(wd);
> +		pci_dev_put(wd->pdev);
> +		if (rc)
> +			return rc;

If the consumer callback fn() returns an error, does this early return
strand the remaining items in the kfifo?

Because cxl_forward_error() takes a pci_dev reference for each enqueued
item, it looks like these stranded items might leak their pci_dev references
and prevent clean unbinding or hot-unplug until a new error triggers the
queue again.

> +	}
> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260505173029.2718246-1-terry.bowman@amd.com?part=1