Re: [PATCH v1 2/4] PCI: designware-plat: Drop unused include

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] In `dw_plat_pcie_probe()`, `pci_epc_init_notify()` is incorrectly called on the error path if `dw_pcie_ep_init_registers()` fails, falsely notifying EPF drivers that the EPC is ready.
--

commit e1010c1890e8eeb7c02639fb9293500993fe3d21
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

PCI: designware-plat: Drop unused include
    
This commit removes the unused <linux/gpio.h> header from the
pcie-designware-plat.c file since its symbols are not used.

> diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
> index d103ab759c4ee..7d896752d43cd 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c

[ ... ]

While reviewing this file, I noticed a pre-existing regression in the
error handling path of dw_plat_pcie_probe():

drivers/pci/controller/dwc/pcie-designware-plat.c:dw_plat_pcie_probe() {
        ...
        ret = dw_pcie_ep_init_registers(&pci->ep);
        if (ret) {
                dev_err(dev, "Failed to initialize DWC endpoint registers\n");
                dw_pcie_ep_deinit(&pci->ep);
        }

        pci_epc_init_notify(pci->ep.epc);
        ...
}

If dw_pcie_ep_init_registers() fails, execution falls through and
unconditionally calls pci_epc_init_notify(pci->ep.epc) rather than returning
an error.

Will this falsely notify all registered endpoint functions that the
endpoint controller was successfully initialized?

Endpoint function drivers react to the epc_init event by attempting
to allocate memory, set BARs, and configure hardware registers. Because
the memory windows are destroyed by dw_pcie_ep_deinit() when it sets
num_windows to 0, could these operations lead to failed memory allocations
or synchronous external aborts when writing to inaccessible registers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260506084858.867884-1-andriy.shevchenko@linux.intel.com?part=2