From: Bjorn Helgaas <helgaas@kernel.org>
To: "Carlos Bilbao (Lambda)" <carlos.bilbao@kernel.org>
Cc: bhelgaas@google.com, eduardo.habkost@lambdal.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
bilbao@vt.edu
Subject: Re: [PATCH] PCI/ASPM: Don't reconfigure ASPM entering low-power state
Date: Wed, 6 May 2026 13:10:12 -0500 [thread overview]
Message-ID: <20260506181012.GA803978@bhelgaas> (raw)
In-Reply-To: <20260428040104.78524-1-carlos.bilbao@kernel.org>
On Mon, Apr 27, 2026 at 09:01:04PM -0700, Carlos Bilbao (Lambda) wrote:
> From: Carlos Bilbao <carlos.bilbao@kernel.org>
>
> Reconfiguring ASPM when a device transitions to low-power state can enable
> L1.1/L1.2 substates on the PCIe link at a time when the device is sleeping
> and may be unable to exit them. ASPM should be reconfigured on D0 entry
> (resume), not on the way down.
>
> pci_set_low_power_state() calls pcie_aspm_pm_state_change() after writing
> D3hot to PCI_PM_CTRL. pcie_aspm_pm_state_change() resets link->aspm_capable
> to link->aspm_support and then calls pcie_config_aspm_path(), which can
> enable ASPM L1.1/L1.2 substates on the PCIe link. If the device cannot
> recover the link from L1.2 while in D3hot, subsequent config space reads
> return 0xFFFF ("device inaccessible") and pci_power_up() fails with message
> "Unable to change power state from D3hot to D0, device inaccessible".
Carlos, do you have a few lines of dmesg showing this issue that we
could quote to help people match the issue with this fix?
next prev parent reply other threads:[~2026-05-06 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 4:01 [PATCH] PCI/ASPM: Don't reconfigure ASPM entering low-power state Carlos Bilbao (Lambda)
2026-05-06 18:07 ` Bjorn Helgaas
2026-05-06 18:10 ` Bjorn Helgaas [this message]
2026-05-07 2:51 ` Carlos Bilbao
2026-05-07 21:49 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506181012.GA803978@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao@kernel.org \
--cc=eduardo.habkost@lambdal.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox