Re: [PATCH 9/9] soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Moving `tegra_pmc_early_init()` entirely behind `#if defined(CONFIG_ARM)` drops critical interrupt polarity configuration on 64-bit ARM platforms.
--

commit 3d33d60e285505a610396bfade1e54d01280574f
Author: Thierry Reding <treding@nvidia.com>

soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard

This commit wraps legacy power management controller (PMC) code in a
CONFIG_ARM preprocessor guard. This separates legacy code from code needed
on modern 64-bit ARM platforms.

> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c

[ ... ]

> @@ -4833,6 +4721,125 @@ static struct platform_driver tegra_pmc_driver = {
>  };
>  builtin_platform_driver(tegra_pmc_driver);
>  
> +#if defined(CONFIG_ARM)

[ ... ]

> @@ -4911,3 +4918,4 @@ static int __init tegra_pmc_early_init(void)
>  	return 0;
>  }
>  early_initcall(tegra_pmc_early_init);
> +#endif /* CONFIG_ARM */

Will wrapping tegra_pmc_early_init() entirely behind CONFIG_ARM prevent
interrupt polarity configuration on 64-bit ARM platforms?

Since CONFIG_ARM is only defined for 32-bit ARM (64-bit uses CONFIG_ARM64),
this skips the early initialization entirely on modern systems.

However, tegra_pmc_early_init() is the exclusive caller of
pmc->soc->setup_irq_polarity() after parsing the nvidia,invert-interrupt
device tree property.

Several 64-bit ARM SoCs (such as Tegra186, Tegra194, and Tegra234) define
and rely on this callback to configure the Wake AOWAKE control registers.

Does bypassing this initialization leave the hardware in a default state
that could cause system wake functionality from suspend to behave
incorrectly?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260506-pmc-v1-0-a6de5da7216b@nvidia.com?part=9