Re: [PATCH 2/2] PCI: qcom: Add support for Hawi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The introduced compatible string `qcom,hawi-pcie` deviates from the established `qcom,pcie-<soc>` naming convention.
--

commit 190903f616d8f4e9c8306f764cc2fdb2f6027cd6
Author: Matthew Leung <matthew.leung@oss.qualcomm.com>

PCI: qcom: Add support for Hawi

This commit adds support for the Hawi platform. It introduces a new device
tree match entry for the dual PCIe controllers present on the system.

> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index af6bf5cce65be..80a238aa26b68 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -2121,6 +2121,7 @@ static int qcom_pcie_resume_noirq(struct device *dev)
>  }
>  
>  static const struct of_device_id qcom_pcie_match[] = {
> +	{ .compatible = "qcom,hawi-pcie", .data = &cfg_1_9_0 },

This isn't a bug, but should this compatible string follow the established
qcom,pcie- prefix format used by the other entries?

If renamed to qcom,pcie-hawi, would it also make sense to move this entry
further down in the array to maintain alphabetical sorting?

>  	{ .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 },
>  	{ .compatible = "qcom,pcie-apq8084", .data = &cfg_1_0_0 },
>  	{ .compatible = "qcom,pcie-ipq4019", .data = &cfg_2_4_0 },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-hawi-pcie-v1-0-0c910906f7e5@oss.qualcomm.com?part=2