From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 206DA15539A; Fri, 8 May 2026 04:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778215000; cv=none; b=iXw9QV0mtQRPGOU4tFCQmepnfXhJYf335N5Y6Z6IcCfE2Ae/OBfF5k2JieYRg5pvMFPB5R7sLwBCn5YzJ34bH7y52Ld5kB8uxR1f8TvUM7vzVDa3wbOM8GgELn5x+3IaLTb8yFGxYWa2F2oA/gd1hMNm2QZy5PgI71CCa94z+m4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778215000; c=relaxed/simple; bh=4JWGb0h1kPyv8PmHZcxIucA20RtT8+EdLkS2uS/1Kn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=albJPjTRenzBSPwAV1sfuIhx+97L2WnH9J1gbuG36ZLDnPLG3+5dbhqRcAPRcBCIgywqYNTvwlf5+ZrDiqnLp9GuqdpR/ABl6EpLTBGzOKkxpAHPZiUH2JVM9YDDdD4v7M65h3apKftESiuCxYK3wT2y6F2VH5ukCLjPzVrBTVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T9++uipd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T9++uipd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73747C2BCB0; Fri, 8 May 2026 04:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778214999; bh=4JWGb0h1kPyv8PmHZcxIucA20RtT8+EdLkS2uS/1Kn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T9++uipdD2y8eXSWG2IKzPIr3Loq4cp/Aa/aClw20WqnKOx9xctzHXl4TpXlLtiTV xsePiLbfr1dnQ/bo3m3deBfbxofcC59I2IcgcdnOdZRt3LzH709akuSfqeG++KRJPm AUfyJmG2zuqtXh1bCWx7nasBCjXbCeUskIMMvSVECXFF0WF/nPQnhPsYZtn2ifkvX5 ev7YpHhjQnIvqsLLsP4sS96IK9vaO5cgZR5XzfRdcbjUAXBUTCRkY2pejtoEO8dZWg GxaY3SnBg7Mi4O6T7hF+K5Pn7ekiTkTkh2ftuhAIJ1G+YhzMz8WUs9QBAzS1QbebTP a0jYR8+hhbtrQ== From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , Alex Williamson , Magnus Lindholm , Matt Turner , Richard Henderson , Christophe Leroy , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Dexuan Cui , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Lukas Wunner , "Oliver O'Halloran" , Saurabh Singh Sengar , Shuan He , Srivatsa Bhat , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v7 14/24] alpha/PCI: Fix __pci_mmap_fits() overflow for zero-length BARs Date: Fri, 8 May 2026 04:35:33 +0000 Message-ID: <20260508043543.217179-15-kwilczynski@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508043543.217179-1-kwilczynski@kernel.org> References: <20260508043543.217179-1-kwilczynski@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, __pci_mmap_fits() computes the BAR size using pci_resource_len() - 1, which wraps to a large value when the BAR length is zero, causing the bounds check to incorrectly succeed. Thus, add an early return for empty resources. Fixes: 10a0ef39fbd1 ("PCI/alpha: pci sysfs resources") Tested-by: Magnus Lindholm Tested-by: Shivaprasad G Bhat Reviewed-by: Ilpo Järvinen Acked-by: Magnus Lindholm Signed-off-by: Krzysztof Wilczyński --- arch/alpha/kernel/pci-sysfs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 5c29f1d2821c..8802f955256e 100644 --- a/arch/alpha/kernel/pci-sysfs.c +++ b/arch/alpha/kernel/pci-sysfs.c @@ -37,12 +37,16 @@ static int hose_mmap_page_range(struct pci_controller *hose, static int __pci_mmap_fits(struct pci_dev *pdev, int num, struct vm_area_struct *vma, int sparse) { + resource_size_t len = pci_resource_len(pdev, num); unsigned long nr, start, size; int shift = sparse ? 5 : 0; + if (!len) + return 0; + nr = vma_pages(vma); start = vma->vm_pgoff; - size = ((pci_resource_len(pdev, num) - 1) >> (PAGE_SHIFT - shift)) + 1; + size = ((len - 1) >> (PAGE_SHIFT - shift)) + 1; if (start < size && size - start >= nr) return 1; -- 2.54.0