Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: alex@shazbot.org
Cc: bhelgaas@google.com, jtornosm@redhat.com,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Add D3cold reset quirk for devices with broken/missing FLR
Date: Fri,  8 May 2026 13:05:28 +0200	[thread overview]
Message-ID: <20260508110529.458971-1-jtornosm@redhat.com> (raw)
In-Reply-To: <20260507092518.186c7f1b@shazbot.org>

Hello Alex,

> We should not have driver dependent reset behavior.  If FLR is broken,
> add these devices to the list of devices using quirk_no_flr() and we'll
> fall back to another reset method.  We also shouldn't be implementing a
> variant of pci_pm_reset().  PM reset can also be prioritized over FLR
> via the reset_methods sysfs attribute if the reset method really is
> tied to the usage.  Thanks,
Thank you for your feedback and help

I tested quirk_no_flr() and it works perfectly for mt7925e. The related                                                                                                                                            
mt7922e device was already in that list so this was expected.

However, for the Qualcomm devices, that solution doesn't work and they
need a different approach.

So, I will submit two independent patches for v2: one for mt7925e following
your suggestion with quirk_no_flr(), and another for Qualcomm devices with a
different proposal trying to follow the same idea.

Best regards
José Ignacio


  reply	other threads:[~2026-05-08 11:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 14:29 [PATCH] PCI: Add D3cold reset quirk for devices with broken/missing FLR Jose Ignacio Tornos Martinez
2026-05-07 15:25 ` Alex Williamson
2026-05-08 11:05   ` Jose Ignacio Tornos Martinez [this message]
2026-05-07 22:42 ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508110529.458971-1-jtornosm@redhat.com \
    --to=jtornosm@redhat.com \
    --cc=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox