Re: [PATCH v2] dt-bindings: Fix phandle-array constraints, again

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `maximum` constraint for the 'Single bit index to toggle' in `qcom,smem-states` properties is incorrectly set to 32 instead of 31.
--

commit 20348129b7dc793c517f442ef59bc8d4f2293a0e
Author: Rob Herring (Arm) <robh@kernel.org>

dt-bindings: Fix phandle-array constraints, again

The unfortunately named 'phandle-array' property type is really a matrix
with phandle and fixed arg cells entries. A matrix property should have 2
levels of items constraints.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
> index b30544410d092..33746c238513d 100644
> --- a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
> @@ -42,7 +42,19 @@ properties:
>      description: State bits used by the AP to signal the modem.
>      items:
>        - description: Power control
> +        items:
> +          - description: Phandle to the Shared Memory Point 2 Point device
> +              handling the communication with a remote processor
> +          - description: Single bit index to toggle in the value sent to
> +              the remote processor
> +            maximum: 32

Should this maximum be 31 instead of 32?

A valid bit index for a 32-bit value ranges from 0 to 31. Setting the maximum
to 32 permits a device tree to specify an out-of-bounds bit index, which could
lead to undefined behavior if a driver shifts by 32 on a 32-bit architecture.

This maximum of 32 is also used for the smem-states additions in the other
bindings updated in this patch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507201749.2605365-1-robh@kernel.org?part=1