Re: [PATCH] PCI: dwc: Use DEFINE_SHOW_ATTRIBUTE for ltssm_status debugfs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims 'No functional change intended', while the patch implicitly fixes a memory leak and module unload race condition.
--

commit 3ba9e0fae6d8b7784978dea48b58611a119ad5c9
Author: Hans Zhang <18255117159@163.com>

PCI: dwc: Use DEFINE_SHOW_ATTRIBUTE for ltssm_status debugfs

This commit replaces the custom open function and file operations for
the ltssm_status debugfs file with the DEFINE_SHOW_ATTRIBUTE macro to
reduce boilerplate.

> Replace the custom open function and file_operations with the
> standard DEFINE_SHOW_ATTRIBUTE macro to reduce boilerplate code.
> 
> No functional change intended.

Is the "No functional change intended" description accurate here?

The original code used single_open() but did not provide a .release
callback, which leaks the seq_file on close:

> -static int ltssm_status_open(struct inode *inode, struct file *file)
> -{
> -	return single_open(file, ltssm_status_show, inode->i_private);
> -}

[ ... ]

> -static const struct file_operations dwc_pcie_ltssm_status_ops = {
> -	.open = ltssm_status_open,
> -	.read = seq_read,
> -};
> +DEFINE_SHOW_ATTRIBUTE(ltssm_status);

By migrating to DEFINE_SHOW_ATTRIBUTE(), the new file operations
automatically include .release = single_release and .owner = THIS_MODULE.

Could the commit message be updated to reflect that this implicitly fixes
a seq_file memory leak and a module unload race condition?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508133432.1964491-1-18255117159@163.com?part=1