Re: [PATCH v2] PCI: Disable broken FLR on MediaTek MT7925

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete implementation: Missing MediaTek MT7925 device ID `0x0717` in the FLR quirk list.
--

commit 2cb7494208e4978bb4c09df85e374c7eac96b74d
Author: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>

PCI: Disable broken FLR on MediaTek MT7925

The MediaTek MT7925 WiFi device advertises FLR capability but its
implementation is broken, causing reset to fail and leaving the device in
an undefined state. This commit disables FLR for the device so the PCI core
can fall back to working reset methods like PM reset or bus reset.

> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index caaed1a01dc02..e49136ac5dbfb 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
[ ... ]
> @@ -5619,6 +5620,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x17f0, quirk_no_flr);
>  DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1502, quirk_no_flr);
>  DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1503, quirk_no_flr);
>  DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_MEDIATEK, 0x0616, quirk_no_flr);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_MEDIATEK, 0x7925, quirk_no_flr);

Should this quirk also include the 0x0717 device ID?

The MT7925 driver in drivers/net/wireless/mediatek/mt76/mt7925/pci.c
registers and supports two MediaTek device IDs: 0x7925 and 0x0717. Both IDs
share the same initialization logic, MAC behavior, and firmware.

Since 0x0717 belongs to the same MT7925 family and shares the same
underlying hardware IP, is it likely to have the same broken FLR
implementation?

If so, users with the 0x0717 variant might still experience the VFIO
passthrough undefined state issue if the device is omitted from this quirk
list.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508145153.717641-1-jtornosm@redhat.com?part=1