Re: [PATCH v7 8/8] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing `fwnode_dev_initialized()` causes consumers of the PCI host bridge to indefinitely defer probe or suffer a 30-second boot delay.
--

commit 77e0afe5e647b8f57bcce68df03d0b7040fbfe25
Author: Herve Codina <herve.codina@bootlin.com>

PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node

This commit removes the fwnode_dev_initialized() call during the creation of
the PCI host bridge node to allow devlink to correctly create links for
devices in device-tree overlays.

> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 25fb02c3dc720..53a8a4f30eb66 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -811,7 +811,6 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
>  	 */
>  	of_node_set_flag(np, OF_POPULATED);
>  	fw_devlink_set_device(&np->fwnode, &bridge->dev);
> -	fwnode_dev_initialized(&np->fwnode, true);

Will removing this cause consumers of the PCI host bridge to indefinitely
defer probe or suffer a 30-second boot delay?

The commit message indicates that the device related to this firmware node
is handled using driver core mechanisms and is fully compliant with devlink
expectations. However, isn't bridge->dev a structural device with no bus
(dev->bus == NULL)? If so, it would never undergo driver matching or
probing.

If fwnode_dev_initialized() is removed, FWNODE_FLAG_INITIALIZED is cleared.
When consumer devices are parsed, fw_devlink creates a managed device link
from the consumer to bridge->dev, expecting it to eventually probe. Since
the bridge device never probes, its status remains DL_DEV_NO_DRIVER.

When the consumer device attempts to probe, device_links_check_suppliers()
might see a dormant supplier and return -EPROBE_DEFER.

Additionally, because device_add(&bridge->dev) executes before
of_pci_make_host_bridge_node() attaches the fwnode, device_add() would see a
NULL fwnode and skip the fallback fw_devlink_unblock_consumers() call.

>  
>  	ret = of_changeset_apply(cset);
>  	if (ret)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511155930.34604-1-herve.codina@bootlin.com?part=8