Re: [PATCH v4 01/16] vfio/pci: Register a file handler with Live Update Orchestrator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The Kconfig symbol VFIO_PCI_LIVEUPDATE depends on a non-existent symbol PCI_LIVEUPDATE.
--

commit 0dbf63e191b4b1a239db36bedc83313305585f3a
Author: Vipin Sharma <vipinsh@google.com>

vfio/pci: Register a file handler with Live Update Orchestrator

This commit registers a live update file handler for vfio-pci device
files with stub implementations. It also adds a new experimental Kconfig
option VFIO_PCI_LIVEUPDATE to gate this support.

[ ... ]

> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> index 296bf01e185ec..c12d614fc6c4a 100644
> --- a/drivers/vfio/pci/Kconfig
> +++ b/drivers/vfio/pci/Kconfig
> @@ -42,6 +42,18 @@ config VFIO_PCI_IGD
>  	  and LPC bridge config space.
>  
>  	  To enable Intel IGD assignment through vfio-pci, say Y.
> +
> +config VFIO_PCI_LIVEUPDATE
> +	bool "VFIO PCI support for Live Update (EXPERIMENTAL)"
> +	depends on PCI_LIVEUPDATE

Does PCI_LIVEUPDATE exist in the kernel tree?

Referencing a non-existent config symbol in a depends on clause means the
dependency can never be satisfied. As a result, VFIO_PCI_LIVEUPDATE can never
be enabled.

Was the intended dependency LIVEUPDATE or something similar?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511234802.2280368-1-vipinsh@google.com?part=1