Re: [PATCH 2/2] PCI: Constify slot attributes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete constification: missed `zpci_slot_attr_uid` in `arch/s390/pci/pci_sysfs.c`.
--

commit 81d437e9bb503bcf5cbb6fdfb3f55cfe7eaf8cde
Author: Thomas Weißschuh <linux@weissschuh.net>

PCI: Constify slot attributes
    
The attribute struct are never modified, mark them as const.

> diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c
> index 6d5cd37bfb1e7..7929bb87b1959 100644
> --- a/drivers/pci/slot.c
> +++ b/drivers/pci/slot.c

[ ... ]

> @@ -93,14 +93,14 @@ static void pci_slot_release(struct kobject *kobj)
>  	kfree(slot);
>  }
>  
> -static struct pci_slot_attribute pci_slot_attr_address =
> +static const struct pci_slot_attribute pci_slot_attr_address =
>  	__ATTR(address, S_IRUGO, address_read_file, NULL);
> -static struct pci_slot_attribute pci_slot_attr_max_speed =
> +static const struct pci_slot_attribute pci_slot_attr_max_speed =
>  	__ATTR(max_bus_speed, S_IRUGO, max_speed_read_file, NULL);
> -static struct pci_slot_attribute pci_slot_attr_cur_speed =
> +static const struct pci_slot_attribute pci_slot_attr_cur_speed =
>  	__ATTR(cur_bus_speed, S_IRUGO, cur_speed_read_file, NULL);

Since this constifies the core PCI slot attributes, should the s390
architecture-specific attributes also be marked as const?

Looking at arch/s390/pci/pci_sysfs.c, it defines a struct pci_slot_attribute
and an attribute array that appear to be missed in this patch:

arch/s390/pci/pci_sysfs.c:
static struct pci_slot_attribute zpci_slot_attr_uid =
	__ATTR(uid, 0444, zpci_uid_slot_show, NULL);

static struct attribute *zpci_slot_attrs[] = {
	&zpci_slot_attr_uid.attr,
	NULL,
};

Could these be updated to const as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-sysfs-const-pci-hotplug-v1-0-3b0b6c6f7481@weissschuh.net?part=2