Re: [PATCH v3 20/27] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `?` operator after `into_devres()` causes a compilation error in `drivers/pwm/pwm_th1520.rs`.
--

commit a23bc481c58c23ac450d2b4d6632694158a96cc9
Author: Danilo Krummrich <dakr@kernel.org>

rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized

This commit adds a lifetime parameter to IoMem and ExclusiveIoMem to tie the
mapping to the device's lifetime. It updates the io requests to return the
mapping directly, while providing an into_devres() method for callers that
need device-managed revocation.

> diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
> index 1abf580653fa3..c84321a4d94e1 100644
> --- a/drivers/pwm/pwm_th1520.rs
> +++ b/drivers/pwm/pwm_th1520.rs
[ ... ]
> @@ -352,7 +352,7 @@ fn probe<'bound>(
>              dev,
>              TH1520_MAX_PWM_NUM,
>              try_pin_init!(Th1520PwmDriverData {
> -                iomem <- request.iomap_sized::<TH1520_PWM_REG_SIZE>(),
> +                iomem <- request.iomap_sized::<TH1520_PWM_REG_SIZE>()?.into_devres(),

Since into_devres() returns a Result type, does this need a trailing ?
operator to unwrap the value? It looks like omitting it will cause a type
mismatch and build failure because try_pin_init! expects the unwrapped
Devres value here.

>                  clk <- clk,
>              }),
>          )?;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260517000149.3226762-1-dakr@kernel.org?part=20