Re: [PATCHv2] PCI: hotplug: compaq: fix X86 dependency

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit introduces a redundant X86_32 dependency and the commit message falsely claims it fixes an x86_64 compilation failure.
--

commit 2f32c0aa3739414d8be655780c2734e155b45ea8
Author: Rosen Penev <rosenp@gmail.com>
PCI: hotplug: compaq: fix X86 dependency

This commit restricts the HOTPLUG_PCI_COMPAQ Kconfig dependency from X86
to X86_32. The commit message indicates this is to prevent x86_64 build
failures caused by invalid assembly.

> This driver needs X86_32, not X86. It does not compile on x86_64 because
> of invalid assembly there.

[Severity: Medium]
Is this description accurate?

HOTPLUG_PCI_COMPAQ already depends on PCI_BIOS. In arch/x86/Kconfig,
config PCI_BIOS is defined with depends on X86_32.

Because of this dependency, the driver could not be selected or compiled
on x86_64 even before this patch. Could the commit message be updated to
reflect this?

> diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
> index 3207860b52e42..5074c0ac4ce18 100644
> --- a/drivers/pci/hotplug/Kconfig
> +++ b/drivers/pci/hotplug/Kconfig
> @@ -20,7 +20,7 @@ if HOTPLUG_PCI
>  
>  config HOTPLUG_PCI_COMPAQ
>  	tristate "Compaq PCI Hotplug driver"
> -	depends on X86 && PCI_BIOS
> +	depends on X86_32 && PCI_BIOS

[Severity: Medium]
Does this introduce a redundant check?

Since PCI_BIOS already restricts the build to X86_32, changing X86 to
X86_32 appears to provide no functional difference.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526042614.1013867-1-rosenp@gmail.com?part=1