Re: [PATCH v19 2/3] rust: leds: add Mode trait

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compilation error due to undeclared module 'private'.
--

commit e81e640b175bb4d8e30e9e60973a904d55f53f03
Author: Markus Probst <markus.probst@posteo.de>

rust: leds: add Mode trait

This commit adds the led::Mode trait to allow for other types of led class
devices in led::LedOps.

> diff --git a/rust/kernel/led/normal.rs b/rust/kernel/led/normal.rs
> index 08913e94e2f1b..61ea7a9e7f2c3 100644
> --- a/rust/kernel/led/normal.rs
> +++ b/rust/kernel/led/normal.rs
> @@ -6,11 +6,19 @@
>  
>  use super::*;
>  
> +/// The led mode for the `struct led_classdev`. Leds with this mode can only have a fixed color.
> +pub enum Normal {}
> +
> +impl Mode for Normal {
> +    type Device<'bound, T: LedOps<Mode = Self> + 'bound> = Device<'bound, T>;
> +}
> +impl private::Sealed for Normal {}

[Severity: Low]
Will this compile? The glob import use super::*; only brings public items
from the parent module into scope. Since mod private is private to led.rs,
it seems private::Sealed is not in scope here. Should this explicitly
reference the parent module using impl super::private::Sealed for Normal {}?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-rust_leds-v19-0-2a71085deae3@posteo.de?part=2