From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628213F1648; Wed, 3 Jun 2026 18:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780510628; cv=none; b=J+zySMGtQUnBA/MmBVEjKlmNXnD9lq07nc3tzlUvsJPXOsCuvwwQJ+l9LLyE5rDrgUsZF1kGuCbZFauiqONqLDmkdhJdW7mXOj/j57OngplL4WYpqbUMaKu5GxO+Kj5FFNES0d35ERj0DAhK+K12sWCaAeezcFlgwrliu8EN2qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780510628; c=relaxed/simple; bh=RQ+lhbs/20dpjDWkfLkvzRoH5lgweVzoQtY2ETnzPfE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jqCOtMmsH9h7ey7MjCMw2KSpOCuA3O985E0jqGB8kvHqLgvJgnE308B34/6u/QV4L54JcNRwNx6utSxeUZqfudI54HdpbfczL3HO42lYqPN85nnSAiFXUyc5FIFeByoW/3orWZqs+OQtifwPkqtuWCHPX7VaGixttnMMAlWYot4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=hJJHfpBn; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="hJJHfpBn" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6536wHkB2672300; Wed, 3 Jun 2026 18:16:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=cFYGaeCjhi1C6NNXk 0q/9v/1B4HO6gGEzVR0sxD8XXU=; b=hJJHfpBnUC3b+5892MgEUE0pTvmjwj1s6 u6W5OJ+4G1qfGP0v3H4SKXXvt67WCfh80Ce5Qz8DS3SmvA3M0+X+a1e448npIWNS hwcBERpNEs1eHln63h2qr8cowjueuVvJzNB9+q1L1IQ/k8pYc0y0F59o1dNzI7s4 5QN0Qrk+x7pms6wJGGYlGVdA+w+Hkb7zWubuedIrDwNBePqYbSQh2I3/Q17AqzkQ sfVPCtVmOm6C51QyNwNCWAyJhFD62hMi3UYbqtFiciA1gwuu0azJAGiC0GWNv4VJ 0iuJ0cDjvPQfgeH+8pZ+2fRbyFpSRQu2l5RBNDklV/ZdiSXKLJO+w== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efqhtbr9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 18:16:55 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 653I99Eq004553; Wed, 3 Jun 2026 18:16:55 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4egakw1m48-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 18:16:55 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 653IGrX614680768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Jun 2026 18:16:54 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E534358056; Wed, 3 Jun 2026 18:16:53 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2981F5803F; Wed, 3 Jun 2026 18:16:53 +0000 (GMT) Received: from IBM-D32RQW3.ibm.com (unknown [9.61.254.14]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 3 Jun 2026 18:16:53 +0000 (GMT) From: Farhan Ali To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Cc: helgaas@kernel.org, alex@shazbot.org, alifm@linux.ibm.com, schnelle@linux.ibm.com, mjrosato@linux.ibm.com, Benjamin Block Subject: [PATCH v18 3/3] PCI: Fail FLR when config space is inaccessible Date: Wed, 3 Jun 2026 11:16:47 -0700 Message-ID: <20260603181647.2215-4-alifm@linux.ibm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603181647.2215-1-alifm@linux.ibm.com> References: <20260603181647.2215-1-alifm@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: J3SIv987uA4c3t_fAr4Yug6tcwrxFfKm X-Authority-Analysis: v=2.4 cv=fv/sol4f c=1 sm=1 tr=0 ts=6a206f97 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=1owyFLT6pZZ0tE0DW5YA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE3NSBTYWx0ZWRfX/8lGsEuQDtiE IPSSud/2pgF12nhbnp0AeLqDVGBtLYetUQH7QMb1Xmal+J7Yza1z5Eh82y7lfpCvlvWRmwzWEr1 uhv6EfsczTzqfF+6WSGa6PoMN414oX7IabyfD7I5pWtmRxZitdSKuIvY7c76erS1/9YRyOVNmb1 d1/QoMo4pHqsuo6JOvSy7NuTEBtq6QB/o5rVhbeSrp54kO1EDPEr7/4GGvpkRAru/8coQJIM7ki VL/M6oYVvTtfNDz5jmjHI24f0wVH4n6E+e8QOldWzpSrv1pSUfS0dpg1oFBpq9GeI66lphuqCb6 7xcuHGF/wQYUb5BIq/pc/I1q0OLdJOwbunhHRqQyAOkgpeLNbvEWeOfgBcZ847rNe5vpBqYVJtx UVAWJUT3zsmdGIKsgOmyJQicv9Wk/QGy9SMBgNmtxXS27ePZ9f8x3ycAVtf5n9aCWCX6WSpiFRU oU0fkvJFNDcX7lWZR9g== X-Proofpoint-ORIG-GUID: J3SIv987uA4c3t_fAr4Yug6tcwrxFfKm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_05,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030175 If a device is in an error state, then it's config space may not be accssible. Add additional check to validate if a device's config space is accessible before doing an FLR reset. Reviewed-by: Benjamin Block Reviewed-by: Niklas Schnelle Signed-off-by: Farhan Ali --- drivers/pci/pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 973d23e41c48..061dfcd1472e 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4396,6 +4396,9 @@ int pcie_reset_flr(struct pci_dev *dev, bool probe) if (!(dev->devcap & PCI_EXP_DEVCAP_FLR)) return -ENOTTY; + if (!pci_dev_config_accessible(dev, "FLR")) + return -ENOTTY; + if (probe) return 0; -- 2.43.0