Re: [PATCH v2 1/2] dt-bindings: PCI: qcom,pcie-ipq9574: Add IPQ9650 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema modification fails to make the global interrupt mandatory for IPQ9650 when `msi-map` is used.
--

commit 27378ca447659c2b32e287fcda248ae3808316af
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

dt-bindings: PCI: qcom,pcie-ipq9574: Add IPQ9650 compatible

This commit adds the IPQ9650 PCIe compatible string to the IPQ9574 binding
and updates the constraints to make the global interrupt required for the
IPQ9650 controller.

> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ipq9574.yaml
[ ... ]
> @@ -82,6 +83,18 @@ required:
>  
>  allOf:
>    - $ref: qcom,pcie-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,pcie-ipq9650
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 9
> +        interrupt-names:
> +          minItems: 9

[Severity: Medium]
The commit message mentions making the global interrupt required for IPQ9650,
but does this block actually enforce its presence?

Since qcom,pcie-common.yaml allows interrupts and interrupt-names to be
omitted entirely if an msi-map property is present, a node could omit
the interrupts property completely. If omitted, the minItems constraints
here are skipped, and the node will silently pass validation without
providing the global interrupt.

Should interrupts and interrupt-names also be explicitly added to a
required list within this then block to ensure they cannot be bypassed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610-ipq9650_pcie_binding-v2-0-69e27a1fbf1c@oss.qualcomm.com?part=1