Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Shuan He" <heshuan@bytedance.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v4] PCI/proc: Fix race between pci_proc_init() and pci_bus_add_device()
Date: Fri, 12 Jun 2026 09:26:24 +0900	[thread overview]
Message-ID: <20260612002243.GB2633747@rocinante> (raw)
In-Reply-To: <20260611150543.511422-1-kwilczynski@kernel.org>

Hello,

[...]
> Thus, serialise access to proc_initialized, proc_bus_pci_dir,
> bus->procdir and dev->procent with a new mutex local to the
> drivers/pci/proc.c file, and store the created entries to
> bus->procdir and dev->procent only on success, so a failed
> creation can never overwrite a valid pointer.
> 
> Additionally, wrap the for_each_pci_dev() loop in pci_proc_init() with
> pci_lock_rescan_remove() to serialise against concurrent PCI bus
> operations, add an early return in pci_proc_attach_device() when
> dev->procent is already set to make the function idempotent, and clear
> bus->procdir in pci_proc_detach_bus() to prevent use of a dangling
> pointer after proc_remove().
> 
> Reported-by: Shuan He <heshuan@bytedance.com>
> Closes: https://lore.kernel.org/linux-pci/20250702155112.40124-2-heshuan@bytedance.com/

Applied to procfs branch.

Thank you,

	Krzysztof

  reply	other threads:[~2026-06-12  0:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 15:05 [PATCH v4] PCI/proc: Fix race between pci_proc_init() and pci_bus_add_device() Krzysztof Wilczyński
2026-06-12  0:26 ` Krzysztof Wilczyński [this message]
2026-06-12 15:45 ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260612002243.GB2633747@rocinante \
    --to=kwilczynski@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=heshuan@bytedance.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=lukas@wunner.de \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox