From: Bjorn Helgaas <helgaas@kernel.org>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: sashiko-reviews@lists.linux.dev, linux-pci@vger.kernel.org,
Alex Williamson <alex@shazbot.org>
Subject: Re: [PATCH v18 3/3] PCI: Fail FLR when config space is inaccessible
Date: Fri, 12 Jun 2026 10:44:08 -0500 [thread overview]
Message-ID: <20260612154408.GA608704@bhelgaas> (raw)
In-Reply-To: <1edb130d-8db5-4d48-8f26-1ed24dc544c8@linux.ibm.com>
On Thu, Jun 11, 2026 at 04:29:05PM -0700, Farhan Ali wrote:
> ...
> I do agree exposing both pcie_flr() and pcie_reset_flr() is not ideal, and
> having single API with all the checks would be good. I can take a stab at it
> (separate from this series) and look into either folding the contents of
> pcie_flr() to pcie_reset_flr() or converting all pcie_flr() caller to
> pcie_reset_flr(). AFAICT reset_intel_82599_sfp_virtfn() could be the only
> caller that actually needed to avoid the PCI_EXP_DEVCAP_FLR check.
That would be great. Probably something that should be in linux-next
for quite a while so we have a chance to find any issues.
next prev parent reply other threads:[~2026-06-12 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 18:16 [PATCH v18 0/3] [PCI] Error recovery for vfio-pci devices on s390x Farhan Ali
2026-06-03 18:16 ` [PATCH v18 1/3] PCI: Allow per function PCI slots to fix slot reset on s390 Farhan Ali
2026-06-03 18:33 ` sashiko-bot
2026-06-03 18:16 ` [PATCH v18 2/3] PCI: Avoid saving config space state if inaccessible Farhan Ali
2026-06-03 18:16 ` [PATCH v18 3/3] PCI: Fail FLR when config space is inaccessible Farhan Ali
2026-06-03 18:57 ` sashiko-bot
2026-06-09 22:33 ` Bjorn Helgaas
2026-06-10 16:51 ` Farhan Ali
2026-06-10 20:02 ` Bjorn Helgaas
2026-06-10 21:56 ` Farhan Ali
2026-06-11 19:22 ` Bjorn Helgaas
2026-06-11 23:29 ` Farhan Ali
2026-06-12 15:44 ` Bjorn Helgaas [this message]
2026-06-10 23:44 ` Bjorn Helgaas
2026-06-11 18:22 ` Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612154408.GA608704@bhelgaas \
--to=helgaas@kernel.org \
--cc=alex@shazbot.org \
--cc=alifm@linux.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox