From: sashiko-bot@kernel.org
To: "Manivannan Sadhasivam via B4 Relay"
<devnull+manivannan.sadhasivam.oss.qualcomm.com@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom: Skip PERST# GPIOs provided by downstream PCIe devices
Date: Tue, 16 Jun 2026 16:20:53 +0000 [thread overview]
Message-ID: <20260616162053.CCCA01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260616-pci-qcom-perst-fix-v1-1-27600d6ae357@oss.qualcomm.com>
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> Currently, the pcie-qcom driver recursively parses the PERST# GPIO from all
> child nodes defined in DT and acquires them. But this creates issues with
> PERST# GPIO provided by one of the child devices like the PCIe switch port.
> In this case, the RC driver cannot acquire the PERST# GPIO since it will be
> provided by the child PCIe device which was not yet enumerated during RC
> driver probe.
>
> Fix this by checking if the GPIO provider is a child of the RC's DT node
> (i.e., sits behind this PCIe controller). If so, skip it, as PERST#
> should be controlled by the respective PCIe client driver implementation.
> GPIOs provided by external GPIO controllers (e.g., TLMM in Qcom SoCs)
> continue to be handled normally.
>
> Fixes: 2fd60a2edb83 ("PCI: qcom: Parse PERST# from all PCIe bridge nodes")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260616-pci-qcom-perst-fix-v1-1-27600d6ae357@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-06-16 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 16:15 [PATCH] PCI: qcom: Skip PERST# GPIOs provided by downstream PCIe devices Manivannan Sadhasivam via B4 Relay
2026-06-16 16:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616162053.CCCA01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=devnull+manivannan.sadhasivam.oss.qualcomm.com@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox