From: sashiko-bot@kernel.org
To: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v8 08/25] PCI/sysfs: Warn about BAR resize failure in __resource_resize_store()
Date: Fri, 19 Jun 2026 09:03:56 +0000 [thread overview]
Message-ID: <20260619090357.0E5451F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260619085200.3729431-9-kwilczynski@kernel.org>
> Add a pci_warn() to __resource_resize_store(), so that BAR resize
> failures are visible to the user, which can help troubleshoot any
> potential resource resize issues.
>
> While at it, rename the resource_resize_is_visible() to
> resource_resize_attr_is_visible() along with the corresponding
> group variable to align with the naming convention used by the
> resource attribute groups.
>
> Also, change the order of pci_dev_groups[] such that the resize
> group is now located alongside the other resource groups.
>
> Tested-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260619085200.3729431-1-kwilczynski@kernel.org?part=8
next prev parent reply other threads:[~2026-06-19 9:03 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 8:51 [PATCH v8 00/25] PCI: Convert all dynamic sysfs attributes to static Krzysztof Wilczyński
2026-06-19 8:51 ` [PATCH v8 01/25] PCI/sysfs: Use PCI resource accessor macros Krzysztof Wilczyński
2026-06-19 9:09 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 02/25] PCI: Add pci_resource_is_io() and pci_resource_is_mem() helpers Krzysztof Wilczyński
2026-06-19 8:59 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 03/25] PCI/sysfs: Only allow supported resource types in I/O and MMIO helpers Krzysztof Wilczyński
2026-06-19 9:01 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 04/25] PCI/sysfs: Split pci_llseek_resource() for device and legacy attributes Krzysztof Wilczyński
2026-06-19 9:03 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 05/25] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store() Krzysztof Wilczyński
2026-06-19 9:01 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 06/25] PCI/sysfs: Add static PCI resource attribute macros Krzysztof Wilczyński
2026-06-19 9:11 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 07/25] PCI/sysfs: Convert PCI resource files to static attributes Krzysztof Wilczyński
2026-06-19 9:08 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 08/25] PCI/sysfs: Warn about BAR resize failure in __resource_resize_store() Krzysztof Wilczyński
2026-06-19 9:03 ` sashiko-bot [this message]
2026-06-19 8:51 ` [PATCH v8 09/25] PCI/sysfs: Add stubs for pci_{create,remove}_sysfs_dev_files() Krzysztof Wilczyński
2026-06-19 9:28 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 10/25] PCI/sysfs: Limit pci_sysfs_init() late_initcall compile scope Krzysztof Wilczyński
2026-06-19 9:35 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 11/25] alpha/PCI: Add security_locked_down() check to pci_mmap_resource() Krzysztof Wilczyński
2026-06-19 9:05 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 12/25] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer Krzysztof Wilczyński
2026-06-19 9:02 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 13/25] alpha/PCI: Use PCI resource accessor macros Krzysztof Wilczyński
2026-06-19 9:04 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 14/25] alpha/PCI: Fix __pci_mmap_fits() overflow for zero-length BARs Krzysztof Wilczyński
2026-06-19 9:11 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 15/25] alpha/PCI: Remove WARN from __pci_mmap_fits() and __legacy_mmap_fits() Krzysztof Wilczyński
2026-06-19 8:56 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 16/25] alpha/PCI: Add static PCI resource attribute macros Krzysztof Wilczyński
2026-06-19 9:04 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 17/25] alpha/PCI: Convert resource files to static attributes Krzysztof Wilczyński
2026-06-19 9:09 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 18/25] PCI/sysfs: Remove pci_{create,remove}_sysfs_dev_files() Krzysztof Wilczyński
2026-06-19 9:20 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 19/25] PCI: Add macros for legacy I/O and memory address space sizes Krzysztof Wilczyński
2026-06-19 9:12 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 20/25] alpha/PCI: Compute legacy size in pci_mmap_legacy_page_range() Krzysztof Wilczyński
2026-06-19 9:12 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 21/25] PCI/sysfs: Add __weak pci_legacy_has_sparse() helper Krzysztof Wilczyński
2026-06-19 9:08 ` sashiko-bot
2026-06-19 8:51 ` [PATCH v8 22/25] PCI/sysfs: Add legacy I/O and memory attribute macros Krzysztof Wilczyński
2026-06-19 9:18 ` sashiko-bot
2026-06-19 18:26 ` Krzysztof Wilczyński
2026-06-19 8:51 ` [PATCH v8 23/25] PCI/sysfs: Convert legacy I/O and memory attributes to static definitions Krzysztof Wilczyński
2026-06-19 9:16 ` sashiko-bot
2026-06-19 18:31 ` Krzysztof Wilczyński
2026-06-19 8:51 ` [PATCH v8 24/25] PCI/sysfs: Remove pci_create_legacy_files() and pci_sysfs_init() Krzysztof Wilczyński
2026-06-19 9:11 ` sashiko-bot
2026-06-19 8:52 ` [PATCH v8 25/25] PCI/sysfs: Limit BAR resize attribute scope to platforms with PCI mmap Krzysztof Wilczyński
2026-06-19 9:29 ` sashiko-bot
2026-06-19 18:39 ` [PATCH v8 00/25] PCI: Convert all dynamic sysfs attributes to static Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619090357.0E5451F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox