Re: [PATCH v18 1/8] rust: alloc: add `KBox::into_non_null`

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between SAFETY comment and executed code in `into_non_null`.
--

commit c2c9f847b4c97663dbc3f96c92652dbd5698f0aa
Author: Andreas Hindborg <a.hindborg@kernel.org>

rust: alloc: add KBox::into_non_null

This commit adds an into_non_null() method to Box<T, A> that consumes the box
and returns a NonNull<T>. It acts as a convenience wrapper around
Self::into_raw() for callers requiring a NonNull pointer.

> diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs
> index 35d1e015848dd..d534e8adcf7b3 100644
> --- a/rust/kernel/alloc/kbox.rs
> +++ b/rust/kernel/alloc/kbox.rs
[ ... ]
> @@ -211,6 +211,15 @@ pub fn leak<'a>(b: Self) -> &'a mut T {
>          // which points to an initialized instance of `T`.
>          unsafe { &mut *Box::into_raw(b) }
>      }
> +
> +    /// Consumes the `Box<T,A>` and returns a `NonNull<T>`.
> +    ///
> +    /// Like [`Self::into_raw`], but returns a `NonNull`.
> +    #[inline]
> +    pub fn into_non_null(b: Self) -> NonNull<T> {
> +        // SAFETY: `KBox::into_raw` returns a valid pointer.
> +        unsafe { NonNull::new_unchecked(Self::into_raw(b)) }

[Severity: Low]
This isn't a bug, but there is a mismatch between the safety comment and the
executed code in into_non_null(). The safety comment specifies KBox::into_raw,
but the code executes Self::into_raw(b) on the generic Box<T, A>. 

Would it be better for the comment to reference the actual generic type method
being called to prevent reader confusion?

> +    }
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260625-unique-ref-v18-0-4e06b5896d47@kernel.org?part=1