Re: [PATCH 6.18.y] Revert "PCI: qcom: Advertise Hotplug Slot Capability with no Command Completion support"

[sashiko-bot@kernel.org]

> This reverts commit f176c47683bf6365e2f6d580d557fae49169a703.
> 
> When the Qcom PCIe Root Port advertises itself as hotplug capable, the
> PCI core pre-allocates a conservative 2MB non-prefetchable bridge window
> with 1MB alignment during the initial bus scan. However, the WLAN device
> (17cb:1103) on the ThinkPad X13s requires a 2MB BAR with 2MB alignment,
> which cannot be satisfied from within the pre-allocated bridge window.
> This causes the device to fail enumeration:
> 
>   ath11k_pci 0006:01:00.0: BAR 0 [mem size 0x00200000 64bit]: can't assign; no space
>   ath11k_pci 0006:01:00.0: BAR 0 [??? 0x00000000 flags 0x20000000]: can't assign; bogus alignment
>   ath11k_pci 0006:01:00.0: failed to assign pci resource: -22
>   ath11k_pci 0006:01:00.0: failed to claim device: -22
>   ath11k_pci 0006:01:00.0: probe with driver ath11k_pci failed with error -22
> 
> [ ... ]
> on the Qcom platforms.
> 
> Reported-by: Paul Guder <paul.guder@example.com>
> Closes: https://lore.kernel.org/linux-pci/CAH-zrtu1Bci7M-tQc9Vme9z+Bw=1gthM7z6=XX33Jjd_Q6itcg@mail.gmail.com
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260627080702.11517-1-manivannan.sadhasivam@oss.qualcomm.com?part=1