From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685A528DC4; Tue, 30 Jun 2026 06:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782800711; cv=none; b=NZQMhILaGAvh80gxSkxBQYllaWQ6bBSXP0fmSSAQfjlpL0W6XLzQijBs0Vbwys7iCCNAkBjWblApaPnrfvXz9ARhWEz0b9NlXYlwPftdUoU5bELeoZHPvDgQyrHdIfHSp5Ooa6f/WYRpnd1QRgGwjj08oBYQkGGyk5xn8f9vLLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782800711; c=relaxed/simple; bh=yQDF6daR9hmdhnKHYO09dTsJZYvzr5LzuIphe4/LYCU=; h=From:Subject:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ntud6rf/IvrgCiDQDc9tA+/HPoprx7kZpknzWvPG/xq7xIFD1cioKKH+s11Cv4yO0OEM58LIjLYdF6Ep1jX0iYv1HK6Dtv6SqKnZn3tJewkn4oZmc0FFduejqEAJdfwJRvwkjgJVSegf1zE2mwrJh/xTcdkb2Rs3xlXN7IKlncw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OLAqA19D; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OLAqA19D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B01751F000E9; Tue, 30 Jun 2026 06:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782800710; bh=SlfqcWdSspYUDQt9VOyb0jq/6VppfzyCtLUsCXL39PE=; h=From:Subject:Reply-To:Cc:In-Reply-To:References:Date; b=OLAqA19DRJEqJdaPbVkai6eiOXz7XfOZ8tssTj1451I39TRPGzM6dg/Nr2UfFgLKR M3i+WN5+s6HJkpJlXJOx0yQ2f2Gzl2BnVp+HMk5pqWvQklVIThsHGGNWjmT6rVcuRC 9fvVWBwjLjx3ZfrLmBC55BaEkvZxwT6wigaZ7p/SvM7b0Sf+fohgBkvejIO3CCRLPg /u1cz3+DLcTjqJ+Do80gtZLhIwJxYh1k+lVWlPoweFfGdjP9PCVGSjRs+Mdr9XLvA/ f2Wbx29KB1eUeUTU9g4Tvte0okS1YeBhI3e0FyaHm5iFPCs2+Qr4A2VWttZ0sZ2pjx 20M0ucXYJx4YA== From: sashiko-bot@kernel.org Subject: Re: [PATCH V4 2/7] arm: dts: imx6sx-sdb: Move power supply property to Root Port node Reply-To: sashiko-reviews@lists.linux.dev Cc: linux-pci@vger.kernel.org, Frank.Li@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, imx@lists.linux.dev In-Reply-To: <20260630060710.3294811-3-sherry.sun@oss.nxp.com> References: <20260630060710.3294811-1-sherry.sun@oss.nxp.com> <20260630060710.3294811-3-sherry.sun@oss.nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 30 Jun 2026 06:25:09 +0000 Message-Id: <20260630062509.B01751F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Removing `vpcie-supply` from the host controller node breaks DT ba= ckward compatibility, as older kernels will fail to enable the regulator an= d initialize PCIe. - [Low] Adding `vpcie3v3-supply` to the Root Port node without updating the= corresponding binding schema causes `dtbs_check` validation failures. -- commit 9019771c92c02473e9f2657166c7dc76a65b606d Author: Sherry Sun arm: dts: imx6sx-sdb: Move power supply property to Root Port node Move the power supply property from the PCIe controller node to the Root Port child node to support the new PCI pwrctrl framework. > diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi b/arch/arm/boot/dt= s/nxp/imx/imx6sx-sdb.dtsi > index 338de4d144b2a..41a69fe83be85 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi > @@ -284,12 +284,12 @@ &pcie { > pinctrl-0 =3D <&pinctrl_pcie>; > /* This property is deprecated, use reset-gpios from the Root Port node= . */ > reset-gpio =3D <&gpio2 0 GPIO_ACTIVE_LOW>; > - vpcie-supply =3D <®_pcie_gpio>; [Severity: High] Does removing this property break device tree backward compatibility for older kernels? Older kernels using the pci-imx6.c driver expect the vpcie-supply property in the host controller node to find and enable the regulator. If this is removed instead of being left as a deprecated fallback (similar to the reset-gpio property above), will PCIe initialization fail on older kernels booted with this new device tree? > status =3D "okay"; > }; > =20 > &pcie_port0 { > reset-gpios =3D <&gpio2 0 GPIO_ACTIVE_LOW>; > + vpcie3v3-supply =3D <®_pcie_gpio>; [Severity: Low] Does adding this property to the Root Port node without a corresponding schema update cause dtbs_check validation failures? The fsl,imx6q-pcie.yaml binding schema defines the root port node with unevaluatedProperties: false, but it does not appear to document the newly added vpcie3v3-supply property. [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260630060710.3294= 811-1-sherry.sun@oss.nxp.com?part=3D2