Re: [PATCH v8 2/3] PCI: cadence: Add HPA IP debugfs for LTSSM status

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Modpost link error when building Cadence drivers as modules due to an orphaned debugfs object.
--

commit 98a72e00615e702fb5448b12d14570527e38b67f
Author: Hans Zhang <18255117159@163.com>

PCI: cadence: Add HPA IP debugfs for LTSSM status

This commit adds debugfs support for HPA-based Cadence PCIe controllers,
exposing the current LTSSM state through a new ltssm_status file.

> diff --git a/drivers/pci/controller/cadence/Makefile b/drivers/pci/controller/cadence/Makefile
> index b8ec1cecfaa88..2cdc4617e0c20 100644
> --- a/drivers/pci/controller/cadence/Makefile
> +++ b/drivers/pci/controller/cadence/Makefile
> @@ -4,6 +4,7 @@ pcie-cadence-host-mod-y := pcie-cadence-host-common.o pcie-cadence-host.o pcie-c
>  pcie-cadence-ep-mod-y := pcie-cadence-ep.o
>  
>  obj-$(CONFIG_PCIE_CADENCE) = pcie-cadence-mod.o
> +obj-$(CONFIG_PCIE_CADENCE_DEBUGFS) += pcie-cadence-debugfs.o

[Severity: Low]
Will this cause a link error during modpost when building the Cadence drivers
as modules? 

Since CONFIG_PCIE_CADENCE_DEBUGFS is a boolean, this adds the object directly
to obj-y instead of appending it to a composite module target like
pcie-cadence-mod-y. When the driver is configured as a module (e.g.,
CONFIG_PCIE_CADENCE=m), the object is compiled but left unlinked.

Could this lead to undefined symbol errors for cdns_pcie_debugfs_init and
cdns_pcie_debugfs_deinit in the caller modules?

>  obj-$(CONFIG_PCIE_CADENCE_HOST) += pcie-cadence-host-mod.o
>  obj-$(CONFIG_PCIE_CADENCE_EP) += pcie-cadence-ep-mod.o

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701073513.1101559-1-18255117159@163.com?part=2