Re: [PATCH] rust: device_id: rename IdTable::as_ptr to as_raw_id_table()

[sashiko-bot@kernel.org]

> The current name of `as_ptr` is very generic, and if you attempt to
> invoke `foo.as_ptr()` on a type for which this method is missing, then
> an error along these lines will be printed:
> 
> 	error[E0599]: no method named `as_ptr` found for reference `&DmaBuf` in the current scope
> 	   --> linux/rust/kernel/dma_buf/buf.rs:54:38
> 	    |
> 	 54 |         ptr::eq(self.as_ptr(), other.as_ptr())
> 	    |                                      ^^^^^^ method not found in `&DmaBuf`
> 	    |
> 	    = help: items from traits can only be used if the trait is implemented and in scope
> 	note: `device_id::IdTable` defines an item `as_ptr`, perhaps you need to implement it
> 	   --> linux/rust/kernel/device_id.rs:165:1
> 	    |
> 	165 | pub trait IdTable<T: RawDeviceId, U> {
> 	    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Suggesting the IdTable trait when an as_ptr() method is missing is not
> useful. Renaming it to `as_raw_id_table` makes the method name unique to
> this trait and avoids these bad suggestions.
> 
> Assisted-by: Antigravity:Gemini
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-idtable-rename-asptr-v1-1-e0927273c71a@google.com?part=1