Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v1] PCI: acpiphp_ibm: Do not use uninitialized device_class
Date: Mon, 06 Jul 2026 12:46:32 +0000	[thread overview]
Message-ID: <20260706124632.C20811F000E9@smtp.kernel.org> (raw)
In-Reply-To: <8730724.T7Z3S40VBb@rafael.j.wysocki>

> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> Passing an uninitialized pnp.device_class string to
> acpi_bus_generate_netlink_event() is effectively equivalent
> to passing an empty string literal to it.
> 
> Accordingly, make the driver do the latter instead of doing the
> former.
> 
> No intentional functional impact.
> 
> This will facilitate the removal of device_class from struct
> acpi_device_pnp in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/8730724.T7Z3S40VBb@rafael.j.wysocki?part=1


      reply	other threads:[~2026-07-06 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 12:40 [PATCH v1] PCI: acpiphp_ibm: Do not use uninitialized device_class Rafael J. Wysocki
2026-07-06 12:46 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260706124632.C20811F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox