From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE2C3B8D78; Mon, 6 Jul 2026 17:54:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360468; cv=none; b=oXK35Fqp/WcORlxS7pQOfqAafR1WMy+/ESX2kpi/z0JcQIE2DbCBzmtKjMH7J8BbyCcnWcn847FhK6xtYtDEhHaNMwn488OvrFDYy2g97JhgspafuiOogT3q0IJu5xFJE+Y7Pd1kToP2D6zKzuz8g9KPkEebuzb+8k83nCNwMak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360468; c=relaxed/simple; bh=M7l5Mtfeb55mtqcU/EZZzML3bjTyV6YmpSGkFskhWns=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=lZSN2jxGi2WsI6j+RhfCM4nqkaKiPeEB9YIaM+FzjH9tVR5/fjtDXdFR31n2ZHNx0ES1o66vyS5ZUYczVFuwgzfc3ZmKimXaCuFQuzpuLC73/NXQlURzG6062RI15KDqq5jfO1akDPO9Cai2s+QJcoJoIbP1c+pOnUX6pMxSSJo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gDsF9MPo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gDsF9MPo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF4AF1F00A3E; Mon, 6 Jul 2026 17:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783360466; bh=sHyabwLdiSdyQjfwz7I0N8nEStW6t/tFkfoIupEeLWs=; h=From:To:Cc:Subject:Date; b=gDsF9MPoC6qbMr7gtgMoqux5jRksilmW+/bgeO09vWvK6DhAVr8ZYBFK0FuACrV/N 80sLfuXItj3rxkJDDHivIO/HSiqQUILRRWhfUCF/QeQicEF6oe/X5DDyHQHdcDFtOp 7VP5pKkdrACwEF7OG9dP9L/HHaVl3+zOjxTWTE9fzG+Ba8MnaNBT+zTfRXVT8C5C6n ZhBzo7Nn9kgFufUBJVIZTTjMaDzoOAKu59uJxxfl4WxgSULrX/g+tib16gzBfPNtHK TIbz1W8LhPBeGIHQGih4ZVePJAxQkoJzmsX4i2r1t/LJL1diD82JfYnN8vifKCCI6M /8c/22+4mBY0Q== From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Richard Henderson Cc: Magnus Lindholm , Matt Turner , Ivan Kokshaysky , Jesse Barnes , Bjorn Helgaas , Bjorn Helgaas , linux-alpha@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] alpha/PCI: Fix I/O port accessor argument order in pci_legacy_write() Date: Mon, 6 Jul 2026 17:54:23 +0000 Message-ID: <20260706175423.98305-1-kwilczynski@kernel.org> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pci_legacy_write() in arch/alpha/kernel/pci-sysfs.c passes its arguments to outb(), outw() and outl() in the wrong order: outb(port, val); The Alpha I/O accessors in arch/alpha/include/asm/io.h take the value first and the port second: extern void outb(u8 b, unsigned long port); So the port number is written as data to the I/O address taken from the user-supplied value, and the intended write to the requested port never happens. The arguments have been reversed since the file was added, and the function returns the access size regardless, so the caller sees success while the requested port is left untouched. Fixes: 10a0ef39fbd1 ("PCI/alpha: pci sysfs resources") Tested-by: Magnus Lindholm Reviewed-by: Magnus Lindholm Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Wilczyński --- Changes in v2: https://lore.kernel.org/linux-pci/20260612232400.585195-1-kwilczynski@kernel.org/ - Collected Reviewed-by and Tested-by tags from Magnus Lindholm. arch/alpha/kernel/pci-sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 94dbc470cd6c..7050f0f7fe3d 100644 --- a/arch/alpha/kernel/pci-sysfs.c +++ b/arch/alpha/kernel/pci-sysfs.c @@ -224,17 +224,17 @@ int pci_legacy_write(struct pci_bus *bus, loff_t port, u32 val, size_t size) switch(size) { case 1: - outb(port, val); + outb(val, port); return 1; case 2: if (port & 1) return -EINVAL; - outw(port, val); + outw(val, port); return 2; case 4: if (port & 3) return -EINVAL; - outl(port, val); + outl(val, port); return 4; } return -EINVAL; -- 2.55.0