Re: [PATCH 1/3] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused dummy fixed regulators `vreg_wcn_0p95` and `vreg_wcn_1p9` are left orphaned in the device tree.
--

--- Patch [1]: [PATCH 1/3] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector ---
commit 3a5c700f021e92c47e3fa3997595501dd58c45d6
Author: Wei Deng <wei.deng@oss.qualcomm.com>

arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector

This commit describes the PCIe M.2 Mechanical Key E connector in the hamoa IoT
EVK device tree, linking it to the PCIe 4 Root Port. It replaces the specific
wcn7850-pmu and static BT nodes with chip-agnostic pwrseq-pcie-m2 driver
endpoints.

> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> index 9fa86bb6438ec..41c2004f0ef67 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts

[ ... ]

> @@ -676,65 +714,6 @@ usb_1_ss0_sbu_mux: endpoint {
>  			};
>  		};
>  	};
> -
> -	wcn7850-pmu {
> -		compatible = "qcom,wcn7850-pmu";
> -
> -		vdd-supply = <&vreg_wcn_0p95>;
> -		vddio-supply = <&vreg_l15b_1p8>;
> -		vddaon-supply = <&vreg_wcn_0p95>;
> -		vdddig-supply = <&vreg_wcn_0p95>;
> -		vddrfa1p2-supply = <&vreg_wcn_1p9>;
> -		vddrfa1p8-supply = <&vreg_wcn_1p9>;

[Severity: Low]
Since the wcn7850-pmu node is removed here and the wifi@0 node is removed
below, their consumers are gone.

Should the corresponding fixed regulator definitions for vreg_wcn_0p95 and
vreg_wcn_1p9 also be removed from the device tree?

Leaving them behind might cause the regulator core to needlessly instantiate
these dummy regulators.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-fix-hamoa-m2-w-disable2-v1-0-5e725091266a@oss.qualcomm.com?part=1