From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F318838B12B; Thu, 9 Jul 2026 15:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783611598; cv=none; b=Y0fJo1vZE/wp+dqSAuUG2r6CJ/gvOpWJxSGhxnV4zqyBoU8SQYOu+4uOiMdXWTeZ3p22CUbc+1nGVglzUECi3aTh/26EQ+nUxe85q5MOaEUcS2VaLGLBn6ANq4eOI4qhldUnNgMcq4Snu475rSFmH7pQKZ6G7iJXYHzb3i3HH7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783611598; c=relaxed/simple; bh=alvTFwhUzhXGTq43wIlw+TMhfh8N/Y2ypiQ3JSJ2Z54=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ihXDHa88hMUugINInjYI+v4wwv6QU/kdacEB/5jKDzifGOVeqAEWotJSkuTxsQOb5Glk+XYPklvnvlaCJrPkI6n5ZeXwXYXvRx7Bwdim5lO0pp0c8cGKPpyanFv6iOAWGgmRPqlP4hcF602LXhIe/HaPORVn9Z1UrGMTYzOYPNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ix8Y3txh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ix8Y3txh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 114081F000E9; Thu, 9 Jul 2026 15:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783611592; bh=alvTFwhUzhXGTq43wIlw+TMhfh8N/Y2ypiQ3JSJ2Z54=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ix8Y3txh3gohYMDz3rAjPBAbX+wDYmUcS9Je83i2wBMaWFguR5mKMs65X6U5OP48J EEmQpdTaJQGEv87FCx2M0TW1oH0/vyt3ZNYszdiXrxUq5fgpKJ+kuIuTJ43ozT3OM3 KIQ/JN47kkJovVT4qfAZODwI7M9aGq0j0AUTHCXIFI+Tewn3jp27rOz8qbsjzW9zW+ BY5XxozsIGIp5Z7fs183VTpXyL/o8eQQLbfV4PnoAmbtgq4tv5ciY6jhSLc15Ej71q DLxqurDJZ8XqdMMCwEzCXLCe/O29cRc/5JSkm3UCGlrpFiMrHQkVQVIAzgjVkda6Fh +lFA62YUb/oyw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 04/10] dmaengine: dw-edma: Pass down dw_edma_chan to reduce one level of indirection Reply-To: sashiko-reviews@lists.linux.dev To: Frank.Li@oss.nxp.com Cc: dmaengine@vger.kernel.org, Frank.Li@kernel.org, linux-pci@vger.kernel.org, vkoul@kernel.org, imx@lists.linux.dev In-Reply-To: <20260709-edma_ll-v5-4-e199053d4300@nxp.com> References: <20260709-edma_ll-v5-0-e199053d4300@nxp.com> <20260709-edma_ll-v5-4-e199053d4300@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Jul 2026 15:39:51 +0000 Message-Id: <20260709153952.114081F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > From: Frank Li >=20 > Some helper functions do not use any information from dw_edma_chunk, so > passing a dw_edma_chan pointer directly avoids an unnecessary level of > pointer dereferencing and simplifies data access. >=20 > Tested-by: Koichiro Den > Signed-off-by: Frank Li Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260709-edma_ll-v5= -0-e199053d4300@nxp.com?part=3D4