From: sashiko-bot@kernel.org
To: "Markus Probst" <markus.probst@posteo.de>
Cc: ojeda@kernel.org, linux-pci@vger.kernel.org, lee@kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v22 2/3] rust: leds: add Mode trait
Date: Sun, 12 Jul 2026 17:35:24 +0000 [thread overview]
Message-ID: <20260712173524.A54C61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260712-rust_leds-v22-2-055b0459a079@posteo.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating the LED subsystem guidelines.
--
--- Patch [2]: [PATCH v22 2/3] rust: leds: add Mode trait ---
commit 8d85f0f9ab1eee7120f30390efbe81778a293e33
Author: Markus Probst <markus.probst@posteo.de>
rust: leds: add Mode trait
This commit adds the led::Mode trait to allow for other types of led class
devices in led::LedOps.
> rust: leds: add Mode trait
[Severity: Low]
This isn't a bug, but the LED subsystem guidelines require the commit message
description to be capitalized after the subsystem prefix. Could the subject
line be updated to "rust: leds: Add Mode trait"?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-rust_leds-v22-0-055b0459a079@posteo.de?part=2
next prev parent reply other threads:[~2026-07-12 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 17:26 [PATCH v22 0/3] rust: leds: add led classdev abstractions Markus Probst via B4 Relay
2026-07-12 17:26 ` [PATCH v22 1/3] rust: leds: add basic " Markus Probst via B4 Relay
2026-07-12 17:42 ` sashiko-bot
2026-07-12 17:26 ` [PATCH v22 2/3] rust: leds: add Mode trait Markus Probst via B4 Relay
2026-07-12 17:35 ` sashiko-bot [this message]
2026-07-12 17:26 ` [PATCH v22 3/3] rust: leds: add multicolor classdev abstractions Markus Probst via B4 Relay
2026-07-12 17:40 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712173524.A54C61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox