From: sashiko-bot@kernel.org
To: "Qiang Yu" <qiang.yu@oss.qualcomm.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PCI: qcom: Rename qcom_pcie_set_slot_nccs() to qcom_pcie_set_slot_cap()
Date: Mon, 13 Jul 2026 07:46:33 +0000 [thread overview]
Message-ID: <20260713074633.87EB71F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260713-b4-clear_abp_0713-v2-1-4f0333a98d4e@oss.qualcomm.com>
> qcom_pcie_set_slot_nccs() currently only sets the NCCS field in the Slot
> Capabilities register. A following patch adds programming of another
> field in the same register, so rename the function to
> qcom_pcie_set_slot_cap() to reflect that it configures Slot Capabilities
> as a whole, not just NCCS.
>
> No functional change intended.
>
> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-b4-clear_abp_0713-v2-0-4f0333a98d4e@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-13 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 7:42 [PATCH v2 0/2] PCI: qcom: Clear Attention Button Present in Slot Capabilities Qiang Yu
2026-07-13 7:42 ` [PATCH v2 1/2] PCI: qcom: Rename qcom_pcie_set_slot_nccs() to qcom_pcie_set_slot_cap() Qiang Yu
2026-07-13 7:46 ` sashiko-bot [this message]
2026-07-13 7:42 ` [PATCH v2 2/2] PCI: qcom: Clear Attention Button Present in Slot Capabilities Qiang Yu
2026-07-13 7:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713074633.87EB71F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiang.yu@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox