Re: [PATCH v20 07/16] PCI/TPH: Refactor pcie_enable_tph and add requester variant

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The documentation in `Documentation/PCI/tph.rst` was not updated to reflect the signature change of `pcie_enable_tph()` or the addition of the newly exported `pcie_enable_tph_ext()` API.
--

--- Patch [7]: [PATCH v20 07/16] PCI/TPH: Refactor pcie_enable_tph and add requester variant ---
commit 644907fcc1b63e61928d9441e443b763ecf84aa7
Author: Chengwen Feng <fengchengwen@huawei.com>

PCI/TPH: Refactor pcie_enable_tph and add requester variant

This commit refactors the TPH enable logic by renaming the original function
to pcie_enable_tph_ext() and accepting an explicit requester type argument.
It also updates the signature of the pcie_enable_tph() compatibility wrapper
to use u8 for the mode parameter.

> diff --git a/drivers/pci/tph.c b/drivers/pci/tph.c
> index d123f91775c65..1239a919b9a49 100644
> --- a/drivers/pci/tph.c
> +++ b/drivers/pci/tph.c

[ ... ]

> @@ -463,6 +465,23 @@ int pcie_enable_tph(struct pci_dev *pdev, int mode)
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL(pcie_enable_tph_ext);
> +
> +/**
> + * pcie_enable_tph - Enable TPH support for device using a specific ST mode
> + * @pdev: PCI device
> + * @mode: ST mode to enable: PCI_TPH_ST_(NS_MODE / IV_MODE / DS_MODE)
> + *
> + * Wrapper for pcie_enable_tph_ext(), automatically uses the pre-cached
> + * tph_max_type value (negotiated maximum requester type between device and
> + * root port).
> + *
> + * Return: 0 on success, otherwise negative value (-errno)
> + */
> +int pcie_enable_tph(struct pci_dev *pdev, u8 mode)

[Severity: Low]
Should Documentation/PCI/tph.rst be updated to reflect these changes?

The documentation currently shows the signature as:

  int pcie_enable_tph(struct pci_dev *pdev, int mode);

It also does not mention the newly exported pcie_enable_tph_ext() API that
driver authors might need to use.

> +{
> +	return pcie_enable_tph_ext(pdev, mode, pdev->tph_max_type);
> +}
>  EXPORT_SYMBOL(pcie_enable_tph);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714104325.54444-1-fengchengwen@huawei.com?part=7