Re: [PATCH] PCI: xilinx: use fwnode_irq_get() for INTx IRQ lookup

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `dev_err_probe()` causes spurious boot log spam on probe deferral.
--

--- Patch [1]: [PATCH] PCI: xilinx: use fwnode_irq_get() for INTx IRQ lookup ---
commit 3b83750c982aed2e3747f9f586daf87ae00edeec
Author: Rosen Penev <rosenp@gmail.com>

PCI: xilinx: use fwnode_irq_get() for INTx IRQ lookup

This commit replaces irq_of_parse_and_map() with fwnode_irq_get() in
xilinx_pcie_parse_dt(). It also introduces error handling for the returned
IRQ value, propagating negative errors (including -EPROBE_DEFER) up the
stack instead of passing failures to devm_request_irq().

> diff --git a/drivers/pci/controller/pcie-xilinx.c b/drivers/pci/controller/pcie-xilinx.c
> --- a/drivers/pci/controller/pcie-xilinx.c
> +++ b/drivers/pci/controller/pcie-xilinx.c

[ ... ]

> @@ -548,7 +548,10 @@ static int xilinx_pcie_parse_dt(struct xilinx_pcie *pcie)
>  	if (IS_ERR(pcie->reg_base))
>  		return PTR_ERR(pcie->reg_base);
>  
> -	irq = irq_of_parse_and_map(node, 0);
> +	irq = fwnode_irq_get(dev_fwnode(dev), 0);
> +	if (irq < 0)
> +		return irq;
> +

[Severity: Low]
Does this introduce spurious boot log spam during probe deferral?

Since fwnode_irq_get() can return -EPROBE_DEFER, returning it directly here
propagates the deferral up to the caller, xilinx_pcie_probe().

In xilinx_pcie_probe(), the error is handled like this:

	err = xilinx_pcie_parse_dt(pcie);
	if (err) {
		dev_err(dev, "Parsing DT failed\n");
		return err;
	}

Would it make sense to update xilinx_pcie_probe() to use dev_err_probe()
to handle the newly propagated -EPROBE_DEFER quietly?

>  	err = devm_request_irq(dev, irq, xilinx_pcie_intr_handler,
>  			       IRQF_SHARED | IRQF_NO_THREAD,
>  			       "xilinx-pcie", pcie);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715011142.1261469-1-rosenp@gmail.com?part=1