From: sashiko-bot@kernel.org
To: "Markus Probst" <markus.probst@posteo.de>
Cc: linux-leds@vger.kernel.org, lee@kernel.org, ojeda@kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v23 2/3] rust: leds: add Mode trait
Date: Thu, 16 Jul 2026 18:02:38 +0000 [thread overview]
Message-ID: <20260716180238.AF7CE1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716-rust_leds-v23-2-e91f5b608b56@posteo.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized.
--
--- Patch [2]: [PATCH v23 2/3] rust: leds: add Mode trait ---
commit 82637721450ea77b83de47ea809b8962d9011425
Author: Markus Probst <markus.probst@posteo.de>
rust: leds: add Mode trait
This commit introduces the led::Mode trait to allow different types of LED
class devices to be used within led::LedOps.
> rust: leds: add Mode trait
[Severity: Low]
This isn't a bug, but the commit message description is not capitalized.
According to the LED subsystem guidelines, the description following the
subsystem prefix must always be capitalized. Could the subject be updated
to "rust: leds: Add Mode trait" to match standard naming conventions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-rust_leds-v23-0-e91f5b608b56@posteo.de?part=2
next prev parent reply other threads:[~2026-07-16 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 17:51 [PATCH v23 0/3] rust: leds: add led classdev abstractions Markus Probst
2026-07-16 17:51 ` [PATCH v23 1/3] rust: leds: add basic " Markus Probst
2026-07-16 18:40 ` sashiko-bot
2026-07-16 17:51 ` [PATCH v23 2/3] rust: leds: add Mode trait Markus Probst
2026-07-16 18:02 ` sashiko-bot [this message]
2026-07-16 17:51 ` [PATCH v23 3/3] rust: leds: add multicolor classdev abstractions Markus Probst
2026-07-16 18:21 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716180238.AF7CE1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox