Re: [PATCH v5 5/6] dmaengine: dw-edma: Add delegated channel request helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch references undefined identifiers, functions, and struct members, causing an immediate compilation failure.
--

--- Patch [5]: [PATCH v5 5/6] dmaengine: dw-edma: Add delegated channel request helpers ---
commit f70141ab3e5ddf56089460fb55c122b5c8d3c57b
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Add delegated channel request helpers

This commit adds DW eDMA-specific helpers to request and release delegated
channels for remote hosts. It handles transferring interrupt ownership and
attempts to quiesce the channel on release.

> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 89a4c498a17b8..d7febf5ed83d7 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -1178,6 +1178,97 @@ int dw_edma_remove(struct dw_edma_chip *chip)
[ ... ]
> +static int dw_edma_delegate_chan(struct dma_chan *dchan)
> +{
> +	struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan);
> +	int ret = 0;
> +
> +	if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
> +		return -EINVAL;
> +
> +	guard(spinlock_irqsave)(&chan->vc.lock);
> +
> +	if (chan->configured || chan->status != EDMA_ST_IDLE ||
> +	    chan->request != EDMA_REQ_NONE)
> +		ret = -EBUSY;
> +	else
> +		chan->irq_mode = DW_EDMA_CH_IRQ_REMOTE;

[Severity: Low]
Are irq_mode and DW_EDMA_CH_IRQ_REMOTE defined in this kernel tree?

Looking at struct dw_edma_chan, it doesn't appear to have an irq_mode member,
and DW_EDMA_CH_IRQ_REMOTE seems to be undeclared. This will cause a build
failure. Is it possible a prerequisite patch was omitted from this series?

> +
> +	return ret;
> +}
[ ... ]
> +void dw_edma_release_delegated_chan(struct dma_chan *dchan, bool quiesce)
> +{
> +	struct dw_edma_chan *chan;
> +
> +	if (!dchan)
> +		return;
> +
> +	chan = dchan2dw_edma_chan(dchan);
> +	if (quiesce && dw_edma_core_ch_quiesce(chan))

[Severity: Low]
Is dw_edma_core_ch_quiesce() defined? It appears to be undeclared.

> +		dev_warn(chan->dw->chip->dev,
> +			 "failed to quiesce delegated %s channel %u\n",
> +			 chan->dir == EDMA_DIR_WRITE ? "write" : "read",
> +			 chan->id);
> +
> +	scoped_guard(spinlock_irqsave, &chan->vc.lock)
> +		chan->irq_mode = dw_edma_get_default_irq_mode(chan);

[Severity: Low]
Similarly, dw_edma_get_default_irq_mode() appears undeclared here, and
as mentioned above, irq_mode doesn't seem to exist in struct dw_edma_chan.

> +
> +	dma_release_channel(dchan);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717050635.2145014-1-den@valinux.co.jp?part=5