From: Bjorn Helgaas <helgaas@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "Anirudh Srinivasan" <asrinivasan@oss.tenstorrent.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Yixun Lan" <dlan@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Inochi Amaoto" <inochiama@gmail.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"spacemit@lists.linux.dev" <spacemit@lists.linux.dev>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] PCI: Move Spacemit vendor and device IDs to linux/pci_ids.h
Date: Thu, 23 Jul 2026 17:01:40 -0500 [thread overview]
Message-ID: <20260723220140.GA865834@bhelgaas> (raw)
In-Reply-To: <073fbf4b41804285b2df6fbb4efce0ed@realtek.com>
On Thu, Jul 23, 2026 at 01:19:47AM +0000, Ping-Ke Shih wrote:
> Hi PCI maintainers,
>
> Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com> wrote:
> > Move the vendor and device ID for the existing Spacemit K1 PCIe Root
> > Complex to include/linux/pci_ids.h. Also add K3's Root Complex device ID
> > to this header. This is done so that these values can be referenced in
> > the rtw89 driver to enable 36-bit DMA ability in it for WiFi to function
> > on the K3 Pico ITX board.
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> > ---
> > drivers/pci/controller/dwc/pcie-spacemit-k1.c | 3 ---
> > include/linux/pci_ids.h | 4 ++++
> > 2 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > index be20a520255b6..f89c6d46c7684 100644
> > --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> > @@ -21,9 +21,6 @@
> >
> > #include "pcie-designware.h"
> >
> > -#define PCI_VENDOR_ID_SPACEMIT 0x201f
> > -#define PCI_DEVICE_ID_SPACEMIT_K1 0x0001
> > -
> > /* Offsets and field definitions for link management registers */
> > #define K1_PHY_AHB_IRQ_EN 0x0000
> > #define PCIE_INTERRUPT_EN BIT(0)
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 1c9d40e09107d..d6f26cacc8e35 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2640,6 +2640,10 @@
> > #define PCI_VENDOR_ID_SUNIX 0x1fd4
> > #define PCI_DEVICE_ID_SUNIX_1999 0x1999
> >
> > +#define PCI_VENDOR_ID_SPACEMIT 0x201f
> > +#define PCI_DEVICE_ID_SPACEMIT_K1 0x0001
> > +#define PCI_DEVICE_ID_SPACEMIT_K3 0x0002
> > +
> > #define PCI_VENDOR_ID_HINT 0x3388
> > #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
>
> As patch 2/2 obviously goes to wireless-next tree, can I take this
> dependency patch to my tree?
Yes, that's what my Acked-by at
https://lore.kernel.org/all/20260716164336.GA40813@bhelgaas means.
next prev parent reply other threads:[~2026-07-23 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 23:05 [PATCH v2 0/2] Enable WiFi on Spacemit K3 Pico ITX Anirudh Srinivasan
2026-07-16 23:05 ` [PATCH v2 1/2] PCI: Move Spacemit vendor and device IDs to linux/pci_ids.h Anirudh Srinivasan
2026-07-16 23:08 ` sashiko-bot
2026-07-23 1:19 ` Ping-Ke Shih
2026-07-23 22:01 ` Bjorn Helgaas [this message]
2026-07-24 0:05 ` Ping-Ke Shih
2026-07-24 2:23 ` Ping-Ke Shih
2026-07-16 23:05 ` [PATCH v2 2/2] wifi: rtw89: pci: enable 36-bit DMA on spacemit K3 Anirudh Srinivasan
2026-07-16 23:08 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723220140.GA865834@bhelgaas \
--to=helgaas@kernel.org \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=aurelien@aurel32.net \
--cc=bhelgaas@google.com \
--cc=dlan@kernel.org \
--cc=inochiama@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=pkshih@realtek.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox