From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB2343305C; Mon, 27 Jul 2026 18:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=204.191.154.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785176134; cv=none; b=am4RL5HxBzH5v1I91o9ZqPgSTXBVvsC+ImHztf6EvZRG6VkRO8wwpVh34W4nAoXmWwuw8iI5ddWW5qUbtmHbUOM+OOr6RE6M2UaDIijwqPFudWl/kaam1lGl9B5hh/w3BQs/7wYY2121J39O6xEzWJxUIVQdlJJ6iwXXbRzzeIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785176134; c=relaxed/simple; bh=wZh5b9j3IN1dfBMeY4gWUWFxKNS4ygY0JRmIlnf8Bks=; h=From:To:Cc:Date:Message-ID:In-Reply-To:References:MIME-Version: Subject; b=XqelhK3keClx2+yNZOyA/bp865vBH2Pz9MdfhchCgtpnh+f+vRg+Dvz1pVJf/JD4o7Gsf7dUpHBnHWX6Shv8Ix9kI/ExmcU6eSO//YGs0vVSy8zm4hznfrR8KsBIiI+p/chMv6oWPc53g/6DabLucafPNHoPPzYZelC5Bv2nWHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=deltatee.com; spf=pass smtp.mailfrom=deltatee.com; dkim=pass (2048-bit key) header.d=deltatee.com header.i=@deltatee.com header.b=opIao2mK; arc=none smtp.client-ip=204.191.154.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=deltatee.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=deltatee.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=deltatee.com header.i=@deltatee.com header.b="opIao2mK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:Cc:To:From:content-disposition; bh=5XTMOt9qO2Z6D+4H00P13TLfSI2zmt4qEt9F81f4Mw0=; b=opIao2mKLt2IQvbUYOAeEhr+4P eK59E9lt3vgi5DG91fgigXDX8CW4pykdeJlJQJUTczG+Z3UyATOPZWFLmnGjfG4ezmTfptdI9Q3lC Lnz/5tTLm2shAyHnI95/4Be3bpWlVDhNMadoprZ1tXRfNi9CA5x7Ho/6np8RKVyr3gd2qE9atyxrG 4S9DWGol4kDJx6exXB+Lh4JkMv4FRJjfyPvmOfYPmjLWLsFb+5btVFPTaO8lz3h8r0TtzTksx11xI 8XKdn1s3aFc6hwQMd6Dg8NRYxRVtwMJ+ldsPhOiYZn7HVC0Fx5zd7iLRKiX6AXWHohA51rjj91N8V kDLyHHFQ==; Received: from cgy1-donard.priv.deltatee.com ([172.16.1.31]) by ale.deltatee.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1woPrP-000000004xR-0fb7; Mon, 27 Jul 2026 12:15:31 -0600 Received: from gunthorp by cgy1-donard.priv.deltatee.com with local (Exim 4.98.2) (envelope-from ) id 1woPrO-000000002XP-3O9E; Mon, 27 Jul 2026 12:15:30 -0600 From: Logan Gunthorpe To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul Cc: Frank Li , Kelvin Cao , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Dave Jiang , George Ge , Jaeyoung Chung , Logan Gunthorpe , Sangyun Kim , Kyungwook Boo Date: Mon, 27 Jul 2026 12:15:26 -0600 Message-ID: <20260727181526.9672-12-logang@deltatee.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260727181526.9672-1-logang@deltatee.com> References: <20260727181526.9672-1-logang@deltatee.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 172.16.1.31 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org, Frank.li@nxp.com, linux@weissschuh.net, dave.jiang@intel.com, kelvin.cao@microchip.com, george.ge@microchip.com, logang@deltatee.com, jjy600901@snu.ac.kr, sangyun.kim@snu.ac.kr, bookyungwook@gmail.com X-SA-Exim-Mail-From: gunthorp@deltatee.com X-Spam-Level: Subject: [PATCH v3 11/11] dmaengine: plx_dma: fix NULL pointer deref in plx_dma_isr() X-SA-Exim-Version: 4.2.1 (built Sun, 23 Feb 2025 07:57:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) plx_dma_create() registered the interrupt handler with request_irq() before initializing plxdev->bar. If the device raised an interrupt in that window, plx_dma_isr() would dereference the still-NULL bar. Move the bar assignment ahead of request_irq() so everything the handler can touch is initialized before it can run. Reported-by: Sangyun Kim Reported-by: Kyungwook Boo Link: https://lore.kernel.org/all/20260610112121.676561-1-jjy600901@snu.ac.kr Fixes: c2dbcaa8c672 ("dmaengine: plx-dma: Implement hardware initialization and cleanup") Signed-off-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 84941a918b01..409898e92c32 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -504,17 +504,17 @@ static int plx_dma_create(struct pci_dev *pdev) if (!plxdev) return -ENOMEM; - rc = request_irq(pci_irq_vector(pdev, 0), plx_dma_isr, 0, - KBUILD_MODNAME, plxdev); - if (rc) - goto free_plx; - spin_lock_init(&plxdev->ring_lock); tasklet_setup(&plxdev->desc_task, plx_dma_desc_task); RCU_INIT_POINTER(plxdev->pdev, pdev); plxdev->bar = pcim_iomap_table(pdev)[0]; + rc = request_irq(pci_irq_vector(pdev, 0), plx_dma_isr, 0, + KBUILD_MODNAME, plxdev); + if (rc) + goto free_plx; + dma = &plxdev->dma_dev; INIT_LIST_HEAD(&dma->channels); dma_cap_set(DMA_MEMCPY, dma->cap_mask); -- 2.47.3