Re: [PATCH v8 06/12] PCI: liveupdate: Auto-preserve upstream bridges across Live Update

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `for_each_pci_dev_in_path` macro violates standard kernel iterator conventions by not initializing its iterator variable, creating a confusing API that may lead to misuse.
--

--- Patch [6]: [PATCH v8 06/12] PCI: liveupdate: Auto-preserve upstream bridges across Live Update ---
commit 5f902c08492796d638f5197db23659b872ce5e10
Author: David Matlack <dmatlack@google.com>

PCI: liveupdate: Auto-preserve upstream bridges across Live Update

This commit updates the PCI Live Update mechanism to automatically preserve
upstream PCI-to-PCI bridges when a downstream device is preserved. It tracks
the number of downstream devices preserved under each bridge using a
reference count in struct pci_dev_ser.

> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index b41dd572a2d6b..6267c83813d55 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -829,6 +829,9 @@ static inline struct pci_dev *pci_upstream_bridge(struct pci_dev *dev)
>  	return dev->bus->self;
>  }
>  
> +#define for_each_pci_dev_in_path(dev) \
> +	for (; dev; dev = pci_upstream_bridge(dev))

[Severity: Low]
Does this macro violate standard kernel iterator conventions by not
initializing its iterator variable?

Standard Linux kernel for_each iterators typically initialize their loop
variables. By omitting the initialization here, the macro expects the caller
to pre-initialize the variable and then mutates it in place. 

While the current usages in this patch are functionally correct, could this
unexpected behavior lead to confusion and API misuse for future callers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728221007.2098560-1-dmatlack@google.com?part=6