From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+c7604c9fdd7580cca4e0@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] PCI/proc: check user access return values in proc_bus_pci_{read,write}()
Date: Wed, 29 Jul 2026 08:16:14 +0900 [thread overview]
Message-ID: <20260728231419.GA825941@rocinante> (raw)
In-Reply-To: <20260504022231.15501-1-kartikey406@gmail.com>
Hello,
[...]
> Changes in v2:
> - Use get_user()/put_user() and drop access_ok() (Krzysztof)
> - Rename label to err: per kernel convention (Krzysztof)
> - Simplify error path to release runtime-PM and return -EFAULT (Krzysztof)
> - Apply the same fix to proc_bus_pci_read() (Krzysztof)
Looks good, and with changes to the commit log per Bjorn:
Reviewed-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Thank you!
Krzysztof
prev parent reply other threads:[~2026-07-28 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 2:22 [PATCH v2] PCI/proc: check user access return values in proc_bus_pci_{read,write}() Deepanshu Kartikey
2026-05-04 2:44 ` sashiko-bot
2026-06-21 8:22 ` Deepanshu Kartikey
2026-06-22 17:19 ` Bjorn Helgaas
2026-07-25 2:06 ` Deepanshu Kartikey
2026-07-28 21:56 ` Bjorn Helgaas
2026-07-28 23:16 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728231419.GA825941@rocinante \
--to=kwilczynski@kernel.org \
--cc=bhelgaas@google.com \
--cc=kartikey406@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=syzbot+c7604c9fdd7580cca4e0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox