From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: lizf@honeycomb.io
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
regressions@lists.linux.dev, amd-gfx@lists.freedesktop.org,
"Jon Nettleton" <jon@solid-run.com>,
"Jon Nettleton" <jon.nettleton@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Fix BAR resize for devices on a root bus
Date: Fri, 31 Jul 2026 13:54:18 +0900 [thread overview]
Message-ID: <20260731044456.GA257970@rocinante> (raw)
In-Reply-To: <20260712-pci-rebar-root-bus-v2-1-a1b9107a82dc@honeycomb.io>
Hello,
> Assign the released BARs directly from the root bus windows when there
> is no upstream bridge. On failure, roll back through the existing
> restore path exactly as in the bridged case.
>
> The root bus path also had a locking bug that any fix here necessarily
> touches: the old "goto out" jumped to up_read(&pci_bus_sem) without a
> matching down_read() (as does the "goto restore" taken when
> pci_dev_res_add_to_list() fails in the release loop). Take pci_bus_sem
> before the BAR release loop so every path through the function holds
> it exactly once.
Thank you for also fixing this pci_bus_sem imbalance, appreciated.
With that,
Reviewed-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Thank you!
Krzysztof
next prev parent reply other threads:[~2026-07-31 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 21:49 [PATCH v2] PCI: Fix BAR resize for devices on a root bus Liz Fong-Jones via B4 Relay
2026-07-12 22:01 ` sashiko-bot
2026-07-31 4:54 ` Krzysztof Wilczyński [this message]
2026-07-31 16:24 ` Bjorn Helgaas
[not found] ` <CAC0H+B-p5MT4M03MMkbxr_dLjsuThkxPv3--Ciant0i2MvvqDw@mail.gmail.com>
2026-07-31 22:42 ` Bjorn Helgaas
2026-08-01 0:43 ` [PATCH v3] " Liz Fong-Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731044456.GA257970@rocinante \
--to=kwilczynski@kernel.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jon.nettleton@gmail.com \
--cc=jon@solid-run.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lizf@honeycomb.io \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox