From: Bjorn Helgaas <helgaas@kernel.org>
To: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: "thierry.reding@kernel.org" <thierry.reding@kernel.org>,
"mmaddireddy@nvidia.com" <mmaddireddy@nvidia.com>,
"lukas@wunner.de" <lukas@wunner.de>,
"sashiko-reviews@lists.linux.dev"
<sashiko-reviews@lists.linux.dev>,
"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
"treding@nvidia.com" <treding@nvidia.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: Disable NoSnoop and Relaxed ordering for Intel wireless BE200
Date: Fri, 31 Jul 2026 10:24:31 -0500 [thread overview]
Message-ID: <20260731152431.GA1566014@bhelgaas> (raw)
In-Reply-To: <b314134d7e39eb497a17283ce15467914aa054ae.camel@intel.com>
On Thu, Jul 30, 2026 at 08:16:33PM +0000, Grumbach, Emmanuel wrote:
> On Thu, 2026-07-30 at 15:08 -0500, Bjorn Helgaas wrote:
> ...
> > I wonder if the PCI core should disable RO and NoSnoop on Root
> > Ports across the board?
> >
> > I think this would mainly affect MMIO accesses performed by
> > drivers, and I suspect drivers expect those writes to be performed
> > in order, e.g., if the driver writes DMA descriptors to the device
> > followed by a write to a doorbell, those should stay in order. If
> > the RP has RO enabled, those writes may be reordered.
>
> As a device writer I'd say we'd be required to add a memory barrier
> in that case, but we use writel usually.
> Does that include a write vs write ordering? Hm...
Not being an ordering expert, I'm not sure I can make a convincing
argument for whether RO should be enabled or disabled for Root Ports.
Maybe it's easier to argue that whatever the RO setting is, it should
be the same across all platforms because drivers shouldn't have to
adapt to platform differences.
Root Port settings potentially affect several endpoints, and I think it
would be impractical for drivers to request RO settings that might
conflict with each other.
Do you have any visibility into whether and how other OSes actively
configure Root Port RO and NoSnoop across the board, independent of
individual drivers?
next prev parent reply other threads:[~2026-07-31 15:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-21 6:54 [PATCH] PCI: Disable NoSnoop and Relaxed ordering for Intel wireless BE200 Emmanuel Grumbach
2026-06-21 7:12 ` sashiko-bot
2026-06-21 7:30 ` Grumbach, Emmanuel
2026-07-22 14:56 ` Bjorn Helgaas
2026-07-22 15:14 ` Grumbach, Emmanuel
2026-07-22 17:04 ` Bjorn Helgaas
[not found] ` <204d9dab-96de-45fb-867d-20defc0b79e6@nvidia.com>
[not found] ` <534363f87b37ba6f1449d0524400bcfd7fdf5b3e.camel@intel.com>
2026-07-24 10:54 ` Manikanta Maddireddy
2026-07-28 18:03 ` Bjorn Helgaas
2026-07-28 18:21 ` Grumbach, Emmanuel
2026-07-28 19:11 ` Bjorn Helgaas
2026-07-28 19:16 ` Grumbach, Emmanuel
2026-07-28 19:24 ` Bjorn Helgaas
2026-07-28 19:47 ` Grumbach, Emmanuel
2026-07-28 20:18 ` Bjorn Helgaas
2026-07-29 6:49 ` Grumbach, Emmanuel
2026-07-30 4:51 ` Manikanta Maddireddy
2026-07-30 17:28 ` Bjorn Helgaas
2026-07-30 18:45 ` Grumbach, Emmanuel
2026-07-30 20:08 ` Bjorn Helgaas
2026-07-30 20:16 ` Grumbach, Emmanuel
2026-07-31 15:24 ` Bjorn Helgaas [this message]
2026-07-23 6:47 ` Lukas Wunner
2026-06-21 8:10 ` Lukas Wunner
2026-06-21 8:28 ` Grumbach, Emmanuel
2026-07-22 11:01 ` Grumbach, Emmanuel
2026-07-22 14:36 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731152431.GA1566014@bhelgaas \
--to=helgaas@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=miriam.rachel.korenblit@intel.com \
--cc=mmaddireddy@nvidia.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thierry.reding@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox