Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Derek J. Clark" <derekjohn.clark@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] pci: quirks: Disable native PCIe hotplug on MSI Claw A8 root bridge
Date: Thu, 06 Aug 2026 21:56:19 +0000	[thread overview]
Message-ID: <20260806215620.BBC0D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260806214808.1202819-1-derekjohn.clark@gmail.com>

> The MSI Claw A8 (MS-1T8K) hard-locks on resume from s2idle whenever an
> SD/MMC card is present in the onboard Realtek RTS525A card reader
> (10ec:525a), which sits behind root port 0000:00:02.2. The reader's
> PCIe endpoint is fixed/soldered and not user-hotpluggable.
> 
> Firmware advertises this root port as PCIe hotplug-capable, and _OSC
> grants the OS native hotplug control. When native hotplug is OS-owned,
> resuming from s2idle races the port's hotplug/PME resume handling
> against the RTS525A's own resume sequence when a card is present,
> hard-locking the system.
> 
> Two kernel command line parameters were confirmed to prevent the hang:
> pcie_aspm=off and pcie_ports=compat. Both stop the OS from running
> its own hotplug/PME resume path against this port. The former does
> so by dropping _OSC negotiation during boot, skipping the path that
> [ ... ]
> 
> SD card insertion is handled entirely by rtsx_pci's own card-detect logic,
> so is unaffected by this quirk.
> 
> Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806214808.1202819-1-derekjohn.clark@gmail.com?part=1


  reply	other threads:[~2026-08-06 21:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 21:48 [PATCH v2] pci: quirks: Disable native PCIe hotplug on MSI Claw A8 root bridge Derek J. Clark
2026-08-06 21:56 ` sashiko-bot [this message]
2026-08-07  8:53 ` Lukas Wunner
2026-08-08  0:31   ` Derek John Clark
2026-08-08  8:16     ` Lukas Wunner
2026-08-09  3:34       ` Derek John Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806215620.BBC0D1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=derekjohn.clark@gmail.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox